[PATCH] D17092: [X86] Add -mseparate-stack-seg

2017-02-07 Thread Michael LeMay via Phabricator via cfe-commits
mlemay-intel updated this revision to Diff 87453. mlemay-intel added a comment. Removed the portions that are specific to 32-bit segmentation. I plan to resubmit those later as a separate patch. https://reviews.llvm.org/D17092 Files: include/clang/Driver/Options.td Index: include/clang/Dr

Re: [PATCH] D17092: [X86] Add -mseparate-stack-seg

2016-05-07 Thread Michael Kuperstein via cfe-commits
mkuper resigned from this revision. mkuper removed a reviewer: mkuper. mkuper added a comment. I really don't know enough about this part of clang either. http://reviews.llvm.org/D17092 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://

Re: [PATCH] D17092: [X86] Add -mseparate-stack-seg

2016-04-15 Thread Michael LeMay via cfe-commits
mlemay-intel updated this revision to Diff 53920. mlemay-intel added a comment. Revise patch to fix line alignment. http://reviews.llvm.org/D17092 Files: include/clang/Driver/Options.td lib/CodeGen/TargetInfo.cpp test/CodeGen/varargs.c Index: test/CodeGen/varargs.c ==

Re: [PATCH] D17092: [X86] Add -mseparate-stack-seg

2016-03-08 Thread Quentin Colombet via cfe-commits
qcolombet resigned from this revision. qcolombet edited reviewers, added: craig.topper; removed: qcolombet. qcolombet added a comment. Hi Craig, Could you have a look? I am not confident enough with clang to give more feedback than Elena. Cheers, -Quentin http://reviews.llvm.org/D17092 ___

Re: [PATCH] D17092: [X86] Add -mseparate-stack-seg

2016-02-23 Thread Michael LeMay via cfe-commits
mlemay-intel added a comment. Thank you for your feedback! Comment at: lib/CodeGen/TargetInfo.cpp:1569 @@ +1568,3 @@ +CGF.getTarget().getTargetOpts().Features; + if (std::find(TargetFeatures.begin(), TargetFeatures.end(), +"+separate-stack-seg") != TargetFea

Re: [PATCH] D17092: [X86] Add -mseparate-stack-seg

2016-02-22 Thread Elena Demikhovsky via cfe-commits
delena added a subscriber: delena. Comment at: lib/CodeGen/TargetInfo.cpp:1569 @@ +1568,3 @@ +CGF.getTarget().getTargetOpts().Features; + if (std::find(TargetFeatures.begin(), TargetFeatures.end(), +"+separate-stack-seg") != TargetFeatures.end()) { ---