Re: [PATCH] D17330: PR26648: "inline" shouldn't be recognized as a C keyword in MSVC 2013 compatibility mode

rnk added a comment. Thanks, but I don't think we should do this. There's already a lot of code out there (ffmpeg) that is already using clang its current form and it does stuff like this: #if defined(_MSC_VER) && !defined(__clang__) # define inline __inline // More MSVC compatibility

Re: [PATCH] D17330: PR26648: "inline" shouldn't be recognized as a C keyword in MSVC 2013 compatibility mode

OK, so is initial patch a good one? ;-) Andrey On Wed, Feb 17, 2016 at 8:06 PM, David Majnemer wrote: > majnemer added a comment. > > In http://reviews.llvm.org/D17330#354755, @andreybokhanko wrote: > >> In http://reviews.llvm.org/D17330#354730, @majnemer wrote: >> >>

Re: [PATCH] D17330: PR26648: "inline" shouldn't be recognized as a C keyword in MSVC 2013 compatibility mode

andreybokhanko added a comment. In http://reviews.llvm.org/D17330#354730, @majnemer wrote: > Why not just stick clang in C90 mode when targeting C if the > -fms-compatibility-version is 18? > > We have similar code for the C++ mode in >

Re: [PATCH] D17330: PR26648: "inline" shouldn't be recognized as a C keyword in MSVC 2013 compatibility mode

majnemer added a comment. Why not just stick clang in C90 mode when targeting C if the -fms-compatibility-version is 18? We have similar code for the C++ mode in https://github.com/llvm-mirror/clang/blob/master/lib/Driver/Tools.cpp#l5069 http://reviews.llvm.org/D17330

[PATCH] D17330: PR26648: "inline" shouldn't be recognized as a C keyword in MSVC 2013 compatibility mode

andreybokhanko created this revision. andreybokhanko added reviewers: rnk, majnemer, thakis. andreybokhanko added a subscriber: cfe-commits. See PR26648 for full description of the problem. Here I added a new keyword flag (KEYNOMS18_C) for keywords that shouldn't be enabled in MSVC 2013 mode