eugenis added a comment.
r263578, finally
Repository:
rL LLVM
http://reviews.llvm.org/D17360
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
eugenis added a comment.
No, this is not committed.
I've run dcommit in the wrong checkout and landed
http://reviews.llvm.org/D17900 instead.
Repository:
rL LLVM
http://reviews.llvm.org/D17360
___
cfe-commits mailing list
eugenis closed this revision.
eugenis added a comment.
r263180, thanks for the review!
Repository:
rL LLVM
http://reviews.llvm.org/D17360
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
pcc accepted this revision.
pcc added a comment.
This revision is now accepted and ready to land.
LGTM
Comment at: lib/CodeGen/CGExpr.cpp:2484-2485
@@ -2483,3 +2483,4 @@
CheckRecoverableKind RecoverKind = getRecoverableKind(Checked[0].second);
// In cross-DSO CFI mode
eugenis added a comment.
ping
Repository:
rL LLVM
http://reviews.llvm.org/D17360
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
eugenis updated the summary for this revision.
eugenis updated this revision to Diff 49115.
eugenis added a comment.
OK, done. Please take another look.
This is inferior to the original patch in terms of functionality, but the
implementation is a lot simpler.
Repository:
rL LLVM
pcc added a comment.
What I meant was that it looks like a hack that this is being handled in the
driver. The frontend shouldn't care what the value of a trap flag is if a
sanitizer is disabled.
Why are we even emitting checks for disabled sanitizers in the target DSO
anyway? Can we fail open
eugenis added a comment.
This lets us support the following case:
module A checks vcalls and casts, with diagnostics
module B checks vcalls but not casts (but it still has bitsets for vtables),
with diagnostics
then a cast check from module A with a target in module B should print
diagnostics
pcc added a comment.
Why can't we make it so that a trap flag doesn't affect the behaviour if a
sanitizer is disabled (this looks like what
`CodeGenModule::NeedAllVtablesBitSet` is already doing?)
Repository:
rL LLVM
http://reviews.llvm.org/D17360
eugenis created this revision.
eugenis added reviewers: pcc, krasin.
eugenis added a subscriber: cfe-commits.
eugenis set the repository for this revision to rL LLVM.
In the cross-DSO CFI mode a module may be asked to handle any type of
CFI error, even if the module itself is not checked for that
10 matches
Mail list logo