On Thu, Feb 18, 2016 at 5:39 PM, David Blaikie wrote:
> Thanks all! Which compiler flagged this? Wonder if/why Clang didn't flag it
> for me?
It was coming from GCC 4.9. Haven't checked if Clang also has this somewhere.
> On Thu, Feb 18, 2016 at 5:27 AM, Phabricator via cfe-commits
> wrote:
>>
Thanks all! Which compiler flagged this? Wonder if/why Clang didn't flag it
for me?
On Thu, Feb 18, 2016 at 5:27 AM, Phabricator via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> This revision was automatically updated to reflect the committed changes.
> Closed by commit rL261207: Add parent
This revision was automatically updated to reflect the committed changes.
Closed by commit rL261207: Add parentheses around arithmetic in operand of '|'.
(authored by d0k).
Changed prior to commit:
http://reviews.llvm.org/D17375?vs=48301&id=48302#toc
Repository:
rL LLVM
http://reviews.llvm.
bkramer accepted this revision.
bkramer added a comment.
This revision is now accepted and ready to land.
LGTM, will commit it for you.
http://reviews.llvm.org/D17375
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-
congliu updated this revision to Diff 48301.
congliu added a comment.
- Address review comment.
http://reviews.llvm.org/D17375
Files:
tools/llvm-dwp/llvm-dwp.cpp
Index: tools/llvm-dwp/llvm-dwp.cpp
===
--- tools/llvm-dwp/llvm-dwp
bkramer added a comment.
I think this is the wrong solution. Per
http://www.dwarfstd.org/ShowIssue.php?issue=140421.1
2. Calculate a secondary hash H' = (((S >> 32) & MASK(k)) | 1).
[...]
4. Let H = (H + H') modulo M. Repeat at Step 3.
So the OR has to happen before the ADD.
http://re
congliu created this revision.
congliu added a reviewer: bkramer.
congliu added a subscriber: cfe-commits.
Add the parenthese to make it able to build.
http://reviews.llvm.org/D17375
Files:
tools/llvm-dwp/llvm-dwp.cpp
Index: tools/llvm-dwp/llvm-dwp.cpp
