[PATCH] D17407: [Sema] PR25755 Handle out of order designated initializers

2019-04-10 Thread Don Hinton via Phabricator via cfe-commits
hintonda added a comment. ping... Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D17407/new/ https://reviews.llvm.org/D17407 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D17407: [Sema] PR25755 Handle out of order designated initializers

2019-03-23 Thread Don Hinton via Phabricator via cfe-commits
hintonda added a comment. In D17407#1439029 , @xbolva00 wrote: > Please check also https://bugs.llvm.org/show_bug.cgi?id=40030 If you compile with -pedantic, you'll get the following warning: `warning: designated initializers are a C99 feature

[PATCH] D17407: [Sema] PR25755 Handle out of order designated initializers

2019-03-22 Thread Don Hinton via Phabricator via cfe-commits
hintonda added a comment. I took a look at C++ designator restrictions shown here aggregate initialization , and believe it to be orthogonal to this change. Thus, I'd prefer to put that in a separate patch. However, based

[PATCH] D17407: [Sema] PR25755 Handle out of order designated initializers

2019-03-22 Thread Don Hinton via Phabricator via cfe-commits
hintonda added a comment. In D17407#1439029 , @xbolva00 wrote: > Please check also https://bugs.llvm.org/show_bug.cgi?id=40030 Thanks for pointing that out. I was mainly handling asserts, but will add the restrictions as well. Repository: rG LLVM

[PATCH] D17407: [Sema] PR25755 Handle out of order designated initializers

2019-03-22 Thread Dávid Bolvanský via Phabricator via cfe-commits
xbolva00 added a comment. Please check also https://bugs.llvm.org/show_bug.cgi?id=40030 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D17407/new/ https://reviews.llvm.org/D17407 ___ cfe-commits mailing