bcraig accepted this revision.
bcraig added a reviewer: bcraig.
bcraig added a comment.
This revision is now accepted and ready to land.
Committed
http://reviews.llvm.org/D17456
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.ll
jroelofs added a comment.
LGTM
http://reviews.llvm.org/D17456
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
bcraig added a comment.
ping
http://reviews.llvm.org/D17456
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
bcraig updated the summary for this revision.
bcraig added a reviewer: joerg.
bcraig updated this revision to Diff 48687.
bcraig added a comment.
Changed libcxx prefix to libcpp.
Changed BSD forwarding macros to macro functions.
http://reviews.llvm.org/D17456
Files:
include/__bsd_locale_defau
mclow.lists added a comment.
Actually, the prefix we use in the rest of libc++ for private functions is
`__libcpp_` Take a look in type_traits for a bunch of examples.
In general, I'm liking the way this is going. I suspect I will have more
comments later today.
http://reviews.llvm.org/D1745
On Mon, Feb 22, 2016 at 08:25:56AM -0600, Craig, Ben via cfe-commits wrote:
> On 2/19/2016 3:32 PM, Joerg Sonnenberger via cfe-commits wrote:
> >On Fri, Feb 19, 2016 at 06:14:18PM +, Ben Craig via cfe-commits wrote:
> >>Instead of checking _LIBCPP_LOCALE__L_EXTENSIONS all over, instead
> >>chec
On 2/19/2016 3:32 PM, Joerg Sonnenberger via cfe-commits wrote:
On Fri, Feb 19, 2016 at 06:14:18PM +, Ben Craig via cfe-commits wrote:
Instead of checking _LIBCPP_LOCALE__L_EXTENSIONS all over, instead
check it once, and define the various *_l symbols once.
If you want to rename using macro
On Fri, Feb 19, 2016 at 06:14:18PM +, Ben Craig via cfe-commits wrote:
> Instead of checking _LIBCPP_LOCALE__L_EXTENSIONS all over, instead
> check it once, and define the various *_l symbols once.
If you want to rename using macros, please use the argument form. I find
that to provide better
bcraig updated the summary for this revision.
bcraig removed a reviewer: scshunt.
bcraig updated this revision to Diff 48520.
bcraig added a comment.
Switched from _CXX_* prefix to _libcxx_* prefix to avoid link time conflicts
with other C++ library implementations.
Removed Sean Hunt from the re
scshunt added a comment.
Oh man, what did I do to get included on this one? ;)
I haven't worked on LLVM for years, though, so please proceed without me. :)
Sean
http://reviews.llvm.org/D17456
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
jroelofs added a comment.
In http://reviews.llvm.org/D17456#357245, @bcraig wrote:
> In http://reviews.llvm.org/D17456#357232, @jroelofs wrote:
>
> > > The private redirector symbol names are all prefixed with _CXX_* so that
> > > they won't conflict with user symbols,
> >
> >
> > This is more @
bcraig added a comment.
In http://reviews.llvm.org/D17456#357232, @jroelofs wrote:
> > The private redirector symbol names are all prefixed with _CXX_* so that
> > they won't conflict with user symbols,
>
>
> This is more @mclow.lists/@ericwf's domain, but I think __libcxx_ prefixes
> would be
jroelofs added a subscriber: EricWF.
jroelofs added a comment.
> The private redirector symbol names are all prefixed with _CXX_* so that they
> won't conflict with user symbols,
This is more @mclow.lists/@ericwf's domain, but I think __libcxx_ prefixes
would be safer (so that there's no chanc
bcraig created this revision.
bcraig added reviewers: scshunt, howard.hinnant, jroelofs, mclow.lists.
bcraig added a subscriber: cfe-commits.
Herald added a subscriber: jfb.
This is one part of many of a locale refactor. See
http://reviews.llvm.org/D17146 for an idea of where this is going.
Inst
14 matches
Mail list logo
