This revision was automatically updated to reflect the committed changes.
Closed by commit rL262781: [clang-tidy] Extend UnnecessaryCopyInitialization
check to trigger on non… (authored by flx).
Changed prior to commit:
http://reviews.llvm.org/D17488?vs=49884=49885#toc
Repository:
rL LLVM
flx updated this revision to Diff 49884.
flx marked an inline comment as done.
http://reviews.llvm.org/D17488
Files:
clang-tidy/performance/ForRangeCopyCheck.cpp
clang-tidy/performance/UnnecessaryCopyInitialization.cpp
clang-tidy/performance/UnnecessaryCopyInitialization.h
alexfh added inline comments.
Comment at: clang-tidy/utils/FixItHintUtils.cpp:2
@@ +1,3 @@
+//===--- FixItHintUtils.cpp -
+// clang-tidy---===//
+//
Please fix the line break.
http://reviews.llvm.org/D17488
alexfh accepted this revision.
alexfh added a comment.
This revision is now accepted and ready to land.
Looks good. Thanks!
http://reviews.llvm.org/D17488
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
flx added inline comments.
Comment at: clang-tidy/performance/UnnecessaryCopyInitialization.h:19
@@ -18,3 +18,3 @@
-// A check that detects const local variable declarations that are copy
+// A check that detects local variable declarations that are copy
// initialized with
flx removed rL LLVM as the repository for this revision.
flx updated this revision to Diff 49306.
flx marked 5 inline comments as done.
http://reviews.llvm.org/D17488
Files:
clang-tidy/performance/ForRangeCopyCheck.cpp
clang-tidy/performance/UnnecessaryCopyInitialization.cpp
alexfh added inline comments.
Comment at: clang-tidy/performance/UnnecessaryCopyInitialization.cpp:69
@@ +68,3 @@
+ : "the variable '%0' is copy-constructed from a const reference
"
+ "but "
+ "is only used as const reference;
flx created this revision.
flx added a reviewer: alexfh.
flx added a subscriber: cfe-commits.
flx set the repository for this revision to rL LLVM.
Move code shared between UnnecessaryCopyInitialization and ForRangeCopyCheck
into utilities files.
Add more test cases for