Re: [PATCH] D17619: [MSVC Compat] Don't evaluate member base expressions w/o side effects

2016-02-26 Thread Andrey Bokhanko via cfe-commits
andreybokhanko added a comment. @majnemer, this error in the header is now gone. Thank you! On to more errors! ;-) Yours, Andrey Repository: rL LLVM http://reviews.llvm.org/D17619 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

Re: [PATCH] D17619: [MSVC Compat] Don't evaluate member base expressions w/o side effects

2016-02-25 Thread David Majnemer via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL261975: [MSVC Compat] Don't evaluate member base expressions w/o side effects (authored by majnemer). Changed prior to commit: http://reviews.llvm.org/D17619?vs=49109=49150#toc Repository: rL LLVM

Re: [PATCH] D17619: [MSVC Compat] Don't evaluate member base expressions w/o side effects

2016-02-25 Thread Richard Smith via cfe-commits
rsmith accepted this revision. rsmith added a comment. This revision is now accepted and ready to land. Looks terrible, please commit :) http://reviews.llvm.org/D17619 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

Re: [PATCH] D17619: [MSVC Compat] Don't evaluate member base expressions w/o side effects

2016-02-25 Thread David Majnemer via cfe-commits
majnemer updated this revision to Diff 49109. majnemer added a comment. - Refactor this change. http://reviews.llvm.org/D17619 Files: lib/AST/ExprConstant.cpp test/SemaCXX/ms-const-member-expr.cpp Index: test/SemaCXX/ms-const-member-expr.cpp

Re: [PATCH] D17619: [MSVC Compat] Don't evaluate member base expressions w/o side effects

2016-02-25 Thread David Majnemer via cfe-commits
majnemer updated this revision to Diff 49103. majnemer added a comment. - Add support for static data members too. http://reviews.llvm.org/D17619 Files: lib/AST/ExprConstant.cpp test/SemaCXX/ms-const-member-expr.cpp Index: test/SemaCXX/ms-const-member-expr.cpp