thakis closed this revision.
thakis marked 3 inline comments as done.
thakis added a comment.
r262420, thanks!
http://reviews.llvm.org/D17695
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-
hans added a comment.
lgtm2
Comment at: include/clang/Driver/Job.h:142
@@ +141,3 @@
+/// Like Command, but always pretends that the wrapped command succeeded.
+/// the primary command crashes.
+class ForceSuccessCommand : public Command {
The second sentence loo
thakis updated this revision to Diff 49544.
thakis added a comment.
forgot to `svn add` two new test files
http://reviews.llvm.org/D17695
Files:
include/clang/Basic/DiagnosticDriverKinds.td
include/clang/Basic/DiagnosticGroups.td
include/clang/Driver/CC1Options.td
include/clang/Driver/C
thakis added inline comments.
Comment at: lib/Driver/Driver.cpp:2355
@@ +2354,3 @@
+
+// Add pch if needed: "If you do not specify an extension as part of the
+// path name, an extension of .pch is assumed. "
hans wrote:
> Maybe add .pch if needed?
It alre
thakis updated the summary for this revision.
thakis updated this revision to Diff 49541.
thakis marked 5 inline comments as done.
thakis added a comment.
- rebase across jlebar's r261774 => implicit_inputs gone, ForceSuccessCommand
is new
- .h file is found relative to include paths => introduce
hans accepted this revision.
hans added a comment.
This revision is now accepted and ready to land.
Very nice!
I only have some style nits, really. Look forward to using this :-)
Comment at: include/clang/Basic/DiagnosticDriverKinds.td:112
@@ +111,3 @@
+def warn_drv_yc_multiple
thakis updated this revision to Diff 49325.
thakis added a comment.
clean up accidentally duplicate if block
http://reviews.llvm.org/D17695
Files:
include/clang/Basic/DiagnosticDriverKinds.td
include/clang/Basic/DiagnosticGroups.td
include/clang/Driver/Action.h
include/clang/Driver/CLCo
thakis created this revision.
thakis added a reviewer: hans.
thakis added a subscriber: cfe-commits.
In the gcc precompiled header model, one explicitly runs clang with `-x
c++-header` on a .h file to produce a gch file, and then includes the header
with `-include foo.h` and if a .gch file exist
