"Hal Finkel" <hfin...@anl.gov>, "cfe-commits"
> <cfe-commits@lists.llvm.org>
> Sent: Thursday, March 10, 2016 6:38:21 PM
> Subject: Re: [PATCH] D18051: [CUDA] Provide CUDA's vector types
> implemented using clang's vector extension.
> There were ambiguities in
There were ambiguities in overload resolution between vector types and
their base types. I.e. if I had
void foo(int);
void foo(int3);
then call foo(3) was ambiguous.
It wasn't clear whether this extension is supposed to work in C++ at all.
On Thu, Mar 10, 2016 at 4:05 PM, Hal Finkel
hfinkel added a subscriber: hfinkel.
hfinkel added a comment.
In http://reviews.llvm.org/D18051#372490, @tra wrote:
> Ugh. Found more problems with using vector types in C++. Abandoning the idea.
I'm curious, what problems?
http://reviews.llvm.org/D18051
tra abandoned this revision.
tra added a comment.
Ugh. Found more problems with using vector types in C++. Abandoning the idea.
http://reviews.llvm.org/D18051
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
jlebar added inline comments.
Comment at: lib/Headers/__clang_cuda_runtime_wrapper.h:72
@@ -71,1 +71,3 @@
+#if defined(CUDA_VECTOR_TYPES)
+// Prevent inclusion of CUDA's vector_types.h
The compiler driver is responsible for enabling/disabling language
tra added inline comments.
Comment at: lib/Headers/__clang_cuda_runtime_wrapper.h:72
@@ -71,1 +71,3 @@
+#if defined(CUDA_VECTOR_TYPES)
+// Prevent inclusion of CUDA's vector_types.h
jlebar wrote:
> Hm, this is a surprising (to me) way of controlling this
tra updated this revision to Diff 50341.
tra marked an inline comment as done.
tra added a comment.
Removed unneeded struct attributes.
http://reviews.llvm.org/D18051
Files:
lib/Headers/CMakeLists.txt
lib/Headers/__clang_cuda_runtime_wrapper.h
lib/Headers/__clang_cuda_vector_types.h
jlebar added inline comments.
Comment at: lib/Headers/__clang_cuda_runtime_wrapper.h:72
@@ -71,1 +71,3 @@
+#if defined(CUDA_VECTOR_TYPES)
+// Prevent inclusion of CUDA's vector_types.h
Hm, this is a surprising (to me) way of controlling this feature. Can we
tra created this revision.
tra added reviewers: jlebar, jingyue.
tra added a subscriber: cfe-commits.
This provides substantial performance boost on some benchmarks
(~25% on SHOC's FFT) due to vectorized loads/stores.
Unfortunately existing CUDA headers and user code occasionally
take pointer to
