Re: [PATCH] D18071: CodeGen: Mark functions used in vtables as unnamed_addr.

2016-03-13 Thread John McCall via cfe-commits
rjmccall added a comment. I see, they weren't being set on declarations, just definitions. Yes, this seems reasonable. http://reviews.llvm.org/D18071 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/lis

Re: [PATCH] D18071: CodeGen: Mark functions used in vtables as unnamed_addr.

2016-03-14 Thread Reid Kleckner via cfe-commits
rnk accepted this revision. rnk added a reviewer: rnk. rnk added a comment. This revision is now accepted and ready to land. In http://reviews.llvm.org/D18071#373687, @pcc wrote: > Done (this also affects `_purecall` in the MS ABI; I don't think this change > should break anything there, but som

Re: [PATCH] D18071: CodeGen: Mark functions used in vtables as unnamed_addr.

2016-03-14 Thread Peter Collingbourne via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL263464: CodeGen: Mark functions used in vtables as unnamed_addr. (authored by pcc). Changed prior to commit: http://reviews.llvm.org/D18071?vs=50500&id=50622#toc Repository: rL LLVM http://reviews.l

Re: [PATCH] D18071: CodeGen: Mark functions used in vtables as unnamed_addr.

2016-03-14 Thread John McCall via cfe-commits
rjmccall added a comment. Member function comparisons of virtual functions aren't required to work anyway. Itanium just happens to implement them in a way that kindof gets it right (for simple cases). Repository: rL LLVM http://reviews.llvm.org/D18071 ___