This revision was automatically updated to reflect the committed changes.
Closed by commit rL264964: [CUDA] Make unattributed constexpr functions
implicitly host+device. (authored by jlebar).
Changed prior to commit:
http://reviews.llvm.org/D18380?vs=51868&id=52152#toc
Repository:
rL LLVM
h
jlebar marked an inline comment as done.
jlebar added a comment.
Thank you all your time here, Art, Reid, and Richard. Fingers crossed we don't
have to worry about this again for a while...
http://reviews.llvm.org/D18380
___
cfe-commits mailing li
rsmith added a comment.
LGTM
http://reviews.llvm.org/D18380
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
jlebar added a comment.
(Just to be clear, I'm waiting on Richard's review here, even though he lg'ed
an version of this patch.)
http://reviews.llvm.org/D18380
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/ma
tra added a comment.
LGTM.
http://reviews.llvm.org/D18380
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
jlebar added a comment.
In http://reviews.llvm.org/D18380#385240, @tra wrote:
> What if instead of permanently sticking HD attributes on the constexpr
> function, we instead postpone decision to the point of overload resolution
> and figure out effective attributes or call preference based on c
tra added a comment.
I wonder if we can find a way to decide whether particular constexpr function
should be treated as HD or not without relying on particular order the
functions are seen by compiler (or whether they come from system headers).
Right now we're relying on checking overloads of c
jlebar added a comment.
Updated as discussed -- please have a look.
http://reviews.llvm.org/D18380
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
jlebar updated this revision to Diff 51868.
jlebar added a comment.
Update per changes to patch description. Now a constexpr becomes implicitly HD
unless there's a preceeding __device__ overload.
http://reviews.llvm.org/D18380
Files:
include/clang/Basic/DiagnosticSemaKinds.td
include/clang
