Re: [PATCH] D18430: For MS ABI, emit dllexport friend functions defined inline in class

2016-03-29 Thread Stephan Bergmann via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL264841: For MS ABI, emit dllexport friend functions defined inline in class (authored by sberg). Changed prior to commit: http://reviews.llvm.org/D18430?vs=51517&id=52024#toc Repository: rL LLVM htt

Re: [PATCH] D18430: For MS ABI, emit dllexport friend functions defined inline in class

2016-03-24 Thread Stephan Bergmann via cfe-commits
sberg added a comment. Can you please push this, I do not have commit access. Thanks http://reviews.llvm.org/D18430 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D18430: For MS ABI, emit dllexport friend functions defined inline in class

2016-03-24 Thread Reid Kleckner via cfe-commits
rnk accepted this revision. rnk added a comment. This revision is now accepted and ready to land. lgtm http://reviews.llvm.org/D18430 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D18430: For MS ABI, emit dllexport friend functions defined inline in class

2016-03-24 Thread Stephan Bergmann via cfe-commits
sberg created this revision. sberg added a reviewer: rnk. sberg added a subscriber: cfe-commits. ...as that is apparently what MSVC does. This is an updated version of r263738, which had to be reverted in r263740 due to test failures. The original version had erroneously emitted functions that a