ABataev accepted this revision.
ABataev added a comment.
This revision is now accepted and ready to land.
LG
http://reviews.llvm.org/D18488
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
sfantao added a comment.
Hi Alexey,
Thanks for the review!
In http://reviews.llvm.org/D18488#438841, @ABataev wrote:
> Missed a test for printing and serialization/deserialization
Maybe it is `test/OpenMP/target_update_ast_print.cpp` what you were looking
for? Let me know if not.
Thanks
sfantao updated this revision to Diff 58490.
sfantao marked an inline comment as done.
sfantao added a comment.
- Rebase and remove changes from the nesting tests.
http://reviews.llvm.org/D18488
Files:
include/clang/AST/OpenMPClause.h
include/clang/AST/RecursiveASTVisitor.h
ABataev added a comment.
Missed a test for printing and serialization/deserialization
Comment at: test/OpenMP/nesting_of_regions.cpp:1832
@@ -1831,3 +1831,3 @@
for (int i = 0; i < 10; ++i) {
-#pragma omp target update to(a)
+#pragma omp target update from(a)
}
sfantao updated this revision to Diff 58371.
sfantao added a comment.
Implementation and tests only for the `from` clause. Similarly to the `to`
clause, the implementation is based on the infrastructure contributed before
for the `map` clause.
http://reviews.llvm.org/D18488
Files:
