faisalv added a comment.
*ping*
http://reviews.llvm.org/D18495
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
faisalv added a comment.
*ping*
http://reviews.llvm.org/D18495
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
faisalv updated this revision to Diff 51742.
faisalv marked 2 inline comments as done.
faisalv added a comment.
Updated the patch with the following:
- while checking dependent template template arguments at template definition
time, we must accept the more general (pack) as compatible with the
faisalv marked 2 inline comments as done.
Comment at: lib/Sema/SemaTemplate.cpp:793-800
@@ -792,10 +792,2 @@
if (!Default.isInvalid()) {
-// Check only that we have a template template argument. We don't want to
-// try to check well-formedness now, because our
faisalv created this revision.
faisalv added a reviewer: rsmith.
faisalv added a subscriber: cfe-commits.
I'm not sure why this check wasn't being done at template definition time.
I can't devise a test case to trigger the concerns in the deleted comments
below.
Anything I might be missing by
