This revision was automatically updated to reflect the committed changes.
Closed by commit rL264963: [CUDA] Add math forward declares to CUDA header
wrapper. (authored by jlebar).
Changed prior to commit:
http://reviews.llvm.org/D18539?vs=51988&id=52151#toc
Repository:
rL LLVM
http://review
jlebar marked an inline comment as done.
jlebar added a comment.
Thank you for the review, Art!
http://reviews.llvm.org/D18539
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
tra accepted this revision.
tra added a comment.
This revision is now accepted and ready to land.
One nit. LGTM otherwise.
Comment at: lib/Headers/__clang_cuda_math_forward_declares.h:1
@@ +1,2 @@
+/*=== __clang_cuda_cmath.h - Device-side CUDA cmath support ===
+
jlebar updated this revision to Diff 51988.
jlebar added a comment.
Fix typo in wrapper header. (How did this ever work??)
http://reviews.llvm.org/D18539
Files:
lib/Headers/CMakeLists.txt
lib/Headers/__clang_cuda_math_forward_declares.h
lib/Headers/__clang_cuda_runtime_wrapper.h
Index:
jlebar created this revision.
jlebar added reviewers: rnk, rsmith, tra.
jlebar added a subscriber: cfe-commits.
This is necessary for a future patch which will make all constexpr
functions implicitly host+device. cmath may declare constexpr
functions, but these we do *not* want to be host+device.
