Re: [PATCH] D18608: note for top-level consts in function decls tidy

2016-03-31 Thread Alexander Kornienko via cfe-commits
alexfh added a comment. Thank you for the patch, btw! Repository: rL LLVM http://reviews.llvm.org/D18608 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D18608: note for top-level consts in function decls tidy

2016-03-31 Thread Alexander Kornienko via cfe-commits
alexfh added inline comments. Comment at: docs/ReleaseNotes.rst:73 @@ +72,3 @@ + + This check warns about top-level const parameters in function delcartions. + Typo: "delcartions". Fixed in a follow up. Repository: rL LLVM http://reviews.llvm.org/D18608

Re: [PATCH] D18608: note for top-level consts in function decls tidy

2016-03-31 Thread Alexander Kornienko via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL265007: note for top-level consts in function decls tidy (authored by alexfh). Changed prior to commit: http://reviews.llvm.org/D18608?vs=52126=52187#toc Repository: rL LLVM

Re: [PATCH] D18608: note for top-level consts in function decls tidy

2016-03-30 Thread Matt Kulukundis via cfe-commits
fowles marked an inline comment as done. fowles added a comment. http://reviews.llvm.org/D18608 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D18608: note for top-level consts in function decls tidy

2016-03-30 Thread Matt Kulukundis via cfe-commits
fowles updated this revision to Diff 52126. fowles added a comment. - move release note to 3.9 section http://reviews.llvm.org/D18608 Files: docs/ReleaseNotes.rst Index: docs/ReleaseNotes.rst === --- docs/ReleaseNotes.rst +++

Re: [PATCH] D18608: note for top-level consts in function decls tidy

2016-03-30 Thread Richard via cfe-commits
LegalizeAdulthood added inline comments. Comment at: docs/ReleaseNotes.rst:153-154 @@ -152,2 +152,4 @@ + * `readability-avoid-const-params-in-decls +

Re: [PATCH] D18608: note for top-level consts in function decls tidy

2016-03-30 Thread Matt Kulukundis via cfe-commits
fowles added inline comments. Comment at: docs/ReleaseNotes.rst:153-154 @@ -152,2 +152,4 @@ + * `readability-avoid-const-params-in-decls + `_ *

Re: [PATCH] D18608: note for top-level consts in function decls tidy

2016-03-30 Thread Richard via cfe-commits
LegalizeAdulthood added a subscriber: LegalizeAdulthood. Comment at: docs/ReleaseNotes.rst:153-154 @@ -152,2 +152,4 @@ + * `readability-avoid-const-params-in-decls +

[PATCH] D18608: note for top-level consts in function decls tidy

2016-03-30 Thread Matt Kulukundis via cfe-commits
fowles created this revision. fowles added a reviewer: alexfh. fowles added a subscriber: cfe-commits. Add missing release note http://reviews.llvm.org/D18608 Files: docs/ReleaseNotes.rst Index: docs/ReleaseNotes.rst === ---