Re: [PATCH] D18919: [Clang-tidy] Add check "modernize use using"

Eugene.Zelenko added a comment. Please see PR28334. I'm not sure if Krystyna has Bugzilla account, so I report problem here. Repository: rL LLVM http://reviews.llvm.org/D18919 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

Re: [PATCH] D18919: [Clang-tidy] Add check "modernize use using"

krystyna updated this revision to Diff 61895. krystyna marked 5 inline comments as done. Repository: rL LLVM http://reviews.llvm.org/D18919 Files: clang-tidy/modernize/CMakeLists.txt clang-tidy/modernize/ModernizeTidyModule.cpp clang-tidy/modernize/UseUsingCheck.cpp

Re: [PATCH] D18919: [Clang-tidy] Add check "modernize use using"

Prazek accepted this revision. Prazek added a comment. This revision is now accepted and ready to land. shipit LGTM Comment at: clang-tidy/modernize/UseUsingCheck.cpp:71 @@ +70,3 @@ + const auto *MatchedDecl =

Re: [PATCH] D18919: [Clang-tidy] Add check "modernize use using"

krystyna updated this revision to Diff 60697. Repository: rL LLVM http://reviews.llvm.org/D18919 Files: clang-tidy/modernize/CMakeLists.txt clang-tidy/modernize/ModernizeTidyModule.cpp clang-tidy/modernize/UseUsingCheck.cpp clang-tidy/modernize/UseUsingCheck.h docs/ReleaseNotes.rst

Re: [PATCH] D18919: [Clang-tidy] Add check "modernize use using"

etienneb added a subscriber: etienneb. Comment at: clang-tidy/modernize/UseUsingCheck.cpp:32 @@ +31,3 @@ + + diag(MatchedDecl->getLocStart(), "use using instead of typedef") + << FixItHint::CreateReplacement( I think 'using' should be quote. This message is

Re: [PATCH] D18919: [Clang-tidy] Add check "modernize use using"

Eugene.Zelenko added inline comments. Comment at: clang-tidy/modernize/UseUsingCheck.cpp:13 @@ +12,3 @@ +#include "clang/ASTMatchers/ASTMatchFinder.h" +#include + Prazek wrote: > Is this required? It'll be reasonable to run Include What You Use at least on new

Re: [PATCH] D18919: [Clang-tidy] Add check "modernize use using"

Prazek added inline comments. Comment at: clang-tidy/modernize/UseUsingCheck.cpp:13 @@ +12,3 @@ +#include "clang/ASTMatchers/ASTMatchFinder.h" +#include + Is this required? Repository: rL LLVM http://reviews.llvm.org/D18919

Re: [PATCH] D18919: [Clang-tidy] Add check "modernize use using"

krystyna updated this revision to Diff 57007. krystyna marked 8 inline comments as done. Repository: rL LLVM http://reviews.llvm.org/D18919 Files: clang-tidy/modernize/CMakeLists.txt clang-tidy/modernize/ModernizeTidyModule.cpp clang-tidy/modernize/UseUsingCheck.cpp

Re: [PATCH] D18919: [Clang-tidy] Add check "modernize use using"

On Wed, May 4, 2016 at 2:41 PM, Piotr Padlewski via cfe-commits wrote: > Prazek added a comment. > > In http://reviews.llvm.org/D18919#419902, @curdeius wrote: > >> I'm really interested in the manner this check works when a typedef has >> multiple declarations in it

Re: [PATCH] D18919: [Clang-tidy] Add check "modernize use using"

Prazek added a comment. In http://reviews.llvm.org/D18919#419902, @curdeius wrote: > I'm really interested in the manner this check works when a typedef has > multiple declarations in it (same example as in the comment): > > typedef int m_int, *m_int_p, _int_r, m_int_arr[10], (_int_fun)(int,

Re: [PATCH] D18919: [Clang-tidy] Add check "modernize use using"

hokein added inline comments. Comment at: clang-tidy/modernize/UseUsingCheck.cpp:22 @@ +21,3 @@ +void UseUsingCheck::registerMatchers(MatchFinder *Finder) { + if (!getLangOpts().CPlusPlus) +return; Prazek wrote: > hokein wrote: > > Should be CplusPlus11

Re: [PATCH] D18919: [Clang-tidy] Add check "modernize use using"

Prazek added inline comments. Comment at: clang-tidy/modernize/UseUsingCheck.cpp:22 @@ +21,3 @@ +void UseUsingCheck::registerMatchers(MatchFinder *Finder) { + if (!getLangOpts().CPlusPlus) +return; hokein wrote: > Should be CplusPlus11 here. BTW is there any

Re: [PATCH] D18919: [Clang-tidy] Add check "modernize use using"

hokein accepted this revision. hokein added a comment. LGTM with some nits. Comment at: clang-tidy/modernize/UseUsingCheck.cpp:22 @@ +21,3 @@ +void UseUsingCheck::registerMatchers(MatchFinder *Finder) { + if (!getLangOpts().CPlusPlus) +return; Should be

Re: [PATCH] D18919: [Clang-tidy] Add check "modernize use using"

Eugene.Zelenko added a comment. Check is still not mentioned in docs/ReleaseNotes.rst. Repository: rL LLVM http://reviews.llvm.org/D18919 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

Re: [PATCH] D18919: [Clang-tidy] Add check "modernize use using"

Prazek added a comment. lgtm, but I'd rather see Hokein acceptance. Repository: rL LLVM http://reviews.llvm.org/D18919 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D18919: [Clang-tidy] Add check "modernize use using"

krystyna marked 4 inline comments as done. krystyna added a comment. Repository: rL LLVM http://reviews.llvm.org/D18919 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D18919: [Clang-tidy] Add check "modernize use using"

krystyna updated this revision to Diff 55867. Repository: rL LLVM http://reviews.llvm.org/D18919 Files: clang-tidy/modernize/CMakeLists.txt clang-tidy/modernize/ModernizeTidyModule.cpp clang-tidy/modernize/UseUsingCheck.cpp clang-tidy/modernize/UseUsingCheck.h

Re: [PATCH] D18919: [Clang-tidy] Add check "modernize use using"

krystyna added a comment. hide done comments Repository: rL LLVM http://reviews.llvm.org/D18919 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D18919: [Clang-tidy] Add check "modernize use using"

krystyna marked 8 inline comments as done. krystyna added a comment. Repository: rL LLVM http://reviews.llvm.org/D18919 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D18919: [Clang-tidy] Add check "modernize use using"

krystyna updated this revision to Diff 54974. krystyna marked an inline comment as done. Repository: rL LLVM http://reviews.llvm.org/D18919 Files: clang-tidy/modernize/CMakeLists.txt clang-tidy/modernize/ModernizeTidyModule.cpp clang-tidy/modernize/UseUsingCheck.cpp

Re: [PATCH] D18919: [Clang-tidy] Add check "modernize use using"

hokein added inline comments. Comment at: clang-tidy/modernize/ModernizeTidyModule.cpp:49 @@ -47,1 +48,3 @@ CheckFactories.registerCheck("modernize-use-override"); +CheckFactories.registerCheck( +"modernize-use-using"); You can put it in

Re: [PATCH] D18919: [Clang-tidy] Add check "modernize use using"

krystyna removed rL LLVM as the repository for this revision. krystyna updated this revision to Diff 54007. krystyna marked 5 inline comments as done. http://reviews.llvm.org/D18919 Files: clang-tidy/modernize/CMakeLists.txt clang-tidy/modernize/ModernizeTidyModule.cpp

Re: [PATCH] D18919: [Clang-tidy] Add check "modernize use using"

Prazek added inline comments. Comment at: clang-tidy/modernize/UseUsingCheck.cpp:26 @@ +25,3 @@ +/// AST representation of type. +std::string removeExtraASTWords(std::string subject) { + std::pair subs[] = { add static

Re: [PATCH] D18919: [Clang-tidy] Add check "modernize use using"

Eugene.Zelenko added a subscriber: Eugene.Zelenko. Eugene.Zelenko added a comment. Please mention this check in docs/ReleaseNotes.rst (in alphabetical order). Repository: rL LLVM http://reviews.llvm.org/D18919 ___ cfe-commits mailing list