Re: [PATCH] D19059: Reorder ASTNodeKind::AllKindInfo to match NodeKindId.

2016-04-14 Thread Alexander Kornienko via cfe-commits
alexfh added a subscriber: alexfh. alexfh added a comment. No, but I'm working on the solution. Repository: rL LLVM http://reviews.llvm.org/D19059 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listi

Re: [PATCH] D19059: Reorder ASTNodeKind::AllKindInfo to match NodeKindId.

2016-04-14 Thread Alexander Kornienko via cfe-commits
No, but I'm working on the solution. On Apr 14, 2016 11:06, "Piotr Padlewski" wrote: > Prazek added a subscriber: Prazek. > Prazek added a comment. > > Does it solve my problem with isInTemplateInstantiation? :) > > > Repository: > rL LLVM > > http://reviews.llvm.org/D19059 > > > >

Re: [PATCH] D19059: Reorder ASTNodeKind::AllKindInfo to match NodeKindId.

2016-04-14 Thread Piotr Padlewski via cfe-commits
Prazek added a subscriber: Prazek. Prazek added a comment. Does it solve my problem with isInTemplateInstantiation? :) Repository: rL LLVM http://reviews.llvm.org/D19059 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.or

Re: [PATCH] D19059: Reorder ASTNodeKind::AllKindInfo to match NodeKindId.

2016-04-13 Thread Alexander Kornienko via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL266268: Reorder ASTNodeKind::AllKindInfo to match NodeKindId. (authored by alexfh). Changed prior to commit: http://reviews.llvm.org/D19059?vs=53569&id=53647#toc Repository: rL LLVM http://reviews.l

Re: [PATCH] D19059: Reorder ASTNodeKind::AllKindInfo to match NodeKindId.

2016-04-13 Thread Alexander Kornienko via cfe-commits
alexfh marked an inline comment as done. alexfh added a comment. http://reviews.llvm.org/D19059 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D19059: Reorder ASTNodeKind::AllKindInfo to match NodeKindId.

2016-04-13 Thread Alexander Kornienko via cfe-commits
alexfh updated this revision to Diff 53569. alexfh added a comment. Added a Decl descendant for a test. http://reviews.llvm.org/D19059 Files: lib/AST/ASTTypeTraits.cpp unittests/AST/ASTTypeTraitsTest.cpp unittests/ASTMatchers/Dynamic/ParserTest.cpp unittests/ASTMatchers/Dynamic/Registry

Re: [PATCH] D19059: Reorder ASTNodeKind::AllKindInfo to match NodeKindId.

2016-04-13 Thread Samuel Benzaquen via cfe-commits
sbenza added a comment. Those tests are testing the code completion you get in clang-query. The type list must match what that matcher supports. `hasParent` is declared as const internal::ArgumentAdaptingMatcherFunc< internal::HasParentMatcher, internal::TypeList, internal::T

Re: [PATCH] D19059: Reorder ASTNodeKind::AllKindInfo to match NodeKindId.

2016-04-13 Thread Alexander Kornienko via cfe-commits
alexfh updated this revision to Diff 53566. alexfh added a comment. - Added a test http://reviews.llvm.org/D19059 Files: lib/AST/ASTTypeTraits.cpp unittests/AST/ASTTypeTraitsTest.cpp unittests/ASTMatchers/Dynamic/ParserTest.cpp unittests/ASTMatchers/Dynamic/RegistryTest.cpp Index: unit

[PATCH] D19059: Reorder ASTNodeKind::AllKindInfo to match NodeKindId.

2016-04-13 Thread Alexander Kornienko via cfe-commits
alexfh created this revision. alexfh added a reviewer: sbenza. alexfh added a subscriber: cfe-commits. Herald added a subscriber: klimek. AllKindInfo is being indexed by NodeKindId, so the order must match. I've updated the tests, though I'm not sure what exactly they verify and whether the new st