hokein accepted this revision.
hokein added a comment.
This revision is now accepted and ready to land.
LGTM.
http://reviews.llvm.org/D19183
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-c
Prazek added a subscriber: alexfh.
Prazek added a comment.
ping.
@alexfh are you planning to take a look?
http://reviews.llvm.org/D19183
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commi
Prazek removed rL LLVM as the repository for this revision.
Prazek updated this revision to Diff 55295.
http://reviews.llvm.org/D19183
Files:
clang-tidy/modernize/CMakeLists.txt
clang-tidy/modernize/MakeSharedCheck.cpp
clang-tidy/modernize/MakeSharedCheck.h
clang-tidy/modernize/MakeSmartP
Prazek marked 3 inline comments as done.
Prazek added a comment.
Repository:
rL LLVM
http://reviews.llvm.org/D19183
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
hokein added inline comments.
Comment at: test/clang-tidy/modernize-make-shared.cpp:81
@@ +80,3 @@
+
+ std::shared_ptr R(new int());
+
Prazek wrote:
> hokein wrote:
> > Why can't this case convert to `std::shared_ptr R =
> > std::make_shared(new int())`?
> You
Prazek added inline comments.
Comment at: test/clang-tidy/modernize-make-shared.cpp:81
@@ +80,3 @@
+
+ std::shared_ptr R(new int());
+
hokein wrote:
> Why can't this case convert to `std::shared_ptr R =
> std::make_shared(new int())`?
You mean std::shared_ptr R
hokein added a comment.
The patch looks almost good, some nits.
Comment at: clang-tidy/modernize/MakeSmartPtrCheck.cpp:1
@@ +1,2 @@
+
+//===--- MakeSmartPtrCheck.cpp -
clang-tidy===//
Extra blank line.
Comment a
Prazek added a comment.
ping
Repository:
rL LLVM
http://reviews.llvm.org/D19183
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Prazek created this revision.
Prazek added reviewers: alexfh, mnbvmar, staronj, krystyna, angelgarcia.
Prazek added a subscriber: cfe-commits.
Because modernize-make-shared do almos the same job,
I refactored common code to MakeSmartPtrCheck.
http://reviews.llvm.org/D19183
Files:
clang-tidy/
