[PATCH] D19243: [CodeGen] Move some CodeGenPGO stuff out of CodeGenFunction.h

2016-04-18 Thread Vedant Kumar via cfe-commits
vsk created this revision. vsk added a reviewer: bogner. vsk added a subscriber: cfe-commits. Cons: 1 extra malloc per CodeGenFunction instantiation. Pros: This makes incremental builds noticeably faster, especially on my laptop. E.g with this patch there's no need to re-compile clang/lib/CodeG

Re: [PATCH] D19243: [CodeGen] Move some CodeGenPGO stuff out of CodeGenFunction.h

2016-04-18 Thread Vedant Kumar via cfe-commits
vsk updated the summary for this revision. vsk updated this revision to Diff 54128. vsk added a comment. - Remove extraneous whitespace changes. http://reviews.llvm.org/D19243 Files: lib/CodeGen/CGBlocks.cpp lib/CodeGen/CGCall.cpp lib/CodeGen/CGExpr.cpp lib/CodeGen/CGObjC.cpp lib/Code

Re: [PATCH] D19243: [CodeGen] Move some CodeGenPGO stuff out of CodeGenFunction.h

2016-05-01 Thread Justin Bogner via cfe-commits
Vedant Kumar writes: > vsk created this revision. > vsk added a reviewer: bogner. > vsk added a subscriber: cfe-commits. > > Cons: 1 extra malloc per CodeGenFunction instantiation. > > Pros: This makes incremental builds noticeably faster, especially on > my laptop. E.g with this patch there's no

Re: [PATCH] D19243: [CodeGen] Move some CodeGenPGO stuff out of CodeGenFunction.h

2016-05-01 Thread Vedant Kumar via cfe-commits
vsk abandoned this revision. vsk added a comment. It is a bit messy. (Aside: I don't think the size of CodeGenPGO is visible with this change, so unique_ptr/default_delete wouldn't work?) http://reviews.llvm.org/D19243 ___ cfe-commits mailing list