chh closed this revision.
chh added a comment.
Was submitted in r267832 | chh | 2016-04-27 18:09:09 -0700 (Wed, 27 Apr 2016)
http://reviews.llvm.org/D19393
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman
chh marked 2 inline comments as done.
chh added a comment.
I used "svn mv" to move the file and "svn diff --show-copies-as-adds" to
generate the diff.
If I didn't use "--show-copies-as-adds", the new file was not included/shown by
phabricator at all.
Please let me know if there is better way to
srhines added a comment.
Anna, if I scroll over the new include file in phabricator, it shows as a
proper file move (in a yellow column at the start of the right diff - hover for
it to say this). Every line is the same from the original file, as this is
being moved only to fix up the relative p
zaks.anna added a comment.
Would it be possible to generate the diff that shows that the file moved as
opposed to being deleted and added?
http://reviews.llvm.org/D19393
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/
chh updated this revision to Diff 54758.
chh added a comment.
Also move Checkers.td to clang/include/.../Checkers.
http://reviews.llvm.org/D19393
Files:
include/clang/CMakeLists.txt
include/clang/StaticAnalyzer/Checkers/CMakeLists.txt
include/clang/StaticAnalyzer/Checkers/Checkers.td
li
zaks.anna added inline comments.
Comment at: include/clang/StaticAnalyzer/Checkers/CMakeLists.txt:3
@@ +2,3 @@
+ -I ${CMAKE_CURRENT_SOURCE_DIR}/../../../
+ SOURCE ../../../../lib/StaticAnalyzer/Checkers/Checkers.td
+ TARGET ClangSACheckers)
srhines wrote:
> Ann
srhines added inline comments.
Comment at: include/clang/StaticAnalyzer/Checkers/CMakeLists.txt:3
@@ +2,3 @@
+ -I ${CMAKE_CURRENT_SOURCE_DIR}/../../../
+ SOURCE ../../../../lib/StaticAnalyzer/Checkers/Checkers.td
+ TARGET ClangSACheckers)
Anna should probably d
chh added a comment.
See dependent change of ClangTidy.cpp in http://reviews.llvm.org/D19393.
http://reviews.llvm.org/D19393
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
chh created this revision.
chh added reviewers: srhines, alexfh.
chh added a subscriber: cfe-commits.
Herald added subscribers: danalbert, tberghammer.
https://llvm.org/bugs/show_bug.cgi?id=27355
To compile with other binary output directory structures in build systems like
Android.
Allow clang-t
