Thomas <tom.stell...@amd.com>;
xiuli...@outlook.com; cfe-commits@lists.llvm.org
Subject: Re: [PATCH] D19484: [OpenCL] Add supported OpenCL extensions to target
info.
junbuml added a subscriber: junbuml.
junbuml added a comment.
In current trunk, I got build error :
llvm/tools/clang/lib/Basic
junbuml added a subscriber: junbuml.
junbuml added a comment.
In current trunk, I got build error :
llvm/tools/clang/lib/Basic/Targets.cpp:2090:9: error:
'setSupportedOpenCLOpts' overrides a member function but is not marked
'override' [-Werror,-Winconsistent-missing-override]
void
This revision was automatically updated to reflect the committed changes.
Closed by commit rL269431: [OpenCL] Add supported OpenCL extensions to target
info. (authored by yaxunl).
Changed prior to commit:
http://reviews.llvm.org/D19484?vs=57177=57201#toc
Repository:
rL LLVM
bader accepted this revision.
bader added a comment.
LGTM. Thanks!
http://reviews.llvm.org/D19484
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
yaxunl updated this revision to Diff 57177.
yaxunl added a comment.
Fixed available OpenCL version for some extensions.
http://reviews.llvm.org/D19484
Files:
include/clang/Basic/DiagnosticParseKinds.td
include/clang/Basic/LangOptions.h
include/clang/Basic/OpenCLExtensions.def
bader added inline comments.
Comment at: include/clang/Basic/OpenCLExtensions.def:64
@@ +63,3 @@
+OPENCLEXT_INTERNAL(cl_khr_initialize_memory, 200, ~0U)
+OPENCLEXT_INTERNAL(cl_khr_spir, 200, ~0U)
+OPENCLEXT_INTERNAL(cl_khr_srgb_image_writes, 200, ~0U)
Minimum
yaxunl added a comment.
Hi Alexey,
Any comments on this patch?
Thanks.
http://reviews.llvm.org/D19484
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
yaxunl updated this revision to Diff 55839.
yaxunl marked 2 inline comments as done.
yaxunl added a comment.
Add comments about macros for enumerating extensions.
Improve diagnostics about extensions.
http://reviews.llvm.org/D19484
Files:
include/clang/Basic/DiagnosticParseKinds.td
yaxunl added inline comments.
Comment at: test/CodeGenOpenCL/builtins-r600.cl:2
@@ -1,3 +1,3 @@
// REQUIRES: amdgpu-registered-target
-// RUN: %clang_cc1 -triple r600-unknown-unknown -S -emit-llvm -o - %s |
FileCheck %s
+// RUN: %clang_cc1 -triple r600-unknown-unknown
Anastasia accepted this revision.
Anastasia added a comment.
This revision is now accepted and ready to land.
LGTM! Apart from small comments that can be addressed directly before
committing.
Comment at: include/clang/Basic/OpenCLExtensions.def:18
@@ +17,3 @@
+#else
+#define
yaxunl updated this revision to Diff 55600.
yaxunl added a comment.
Add defining macro cl_khr_ for supported extensions or optional core features.
Enable supported extensions or optional core features only if it is available
in the OpenCL version the program is compiled with.
Add spir triple
Anastasia added a comment.
Could you export a full diff please? There are too many small bits here to
review! Thanks!
Comment at: test/SemaOpenCL/extensions.cl:2
@@ +1,3 @@
+// RUN: %clang_cc1 %s -verify -pedantic -fsyntax-only
+// RUN: %clang_cc1 %s -verify -pedantic
yaxunl created this revision.
yaxunl added reviewers: Anastasia, bader.
yaxunl added subscribers: cfe-commits, pxli168, tstellarAMD.
Add supported OpenCL extensions to target info. It serves as default values to
save the users of the burden setting each supported extensions and optional
core
13 matches
Mail list logo
