Re: [PATCH] D19717: [find-all-symbols] Fix racy yaml file writing.

2016-04-29 Thread Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL268021: [find-all-symbols] Fix racy yaml file writing. (authored by d0k). Changed prior to commit: http://reviews.llvm.org/D19717?vs=9=55562#toc Repository: rL LLVM

Re: [PATCH] D19717: [find-all-symbols] Fix racy yaml file writing.

2016-04-29 Thread Haojian Wu via cfe-commits
hokein accepted this revision. hokein added a comment. This revision is now accepted and ready to land. Thanks! LGTM with one nit. Comment at: include-fixer/find-all-symbols/SymbolInfo.h:92 @@ +91,3 @@ +/// \brief Write SymbolInfos to a stream (YAML format). +bool

[PATCH] D19717: [find-all-symbols] Fix racy yaml file writing.

2016-04-29 Thread Benjamin Kramer via cfe-commits
bkramer created this revision. bkramer added a reviewer: hokein. bkramer added a subscriber: cfe-commits. If multiple find-all-symbols processes access the temporary directory simultaneously with two files with the same name they would collide and create a broken yaml file. Fix this by using the