aaboud added a subscriber: aaboud.
Comment at: cfe/trunk/lib/Sema/SemaAttr.cpp:110
@@ -200,3 +109,3 @@
case POAK_Reset:
// Reset just pops the top of the stack, or resets the current alignment to
You forgot to initialize "Alignment" in this case.
This is
This revision was automatically updated to reflect the committed changes.
Closed by commit rL268085: [MS] Make #pragma pack use PragmaStack<> class.
(authored by dzobnin).
Changed prior to commit:
http://reviews.llvm.org/D19727?vs=55598&id=55634#toc
Repository:
rL LLVM
http://reviews.llvm.o
rnk accepted this revision.
rnk added a comment.
This revision is now accepted and ready to land.
lgtm
Comment at: include/clang/Sema/Sema.h:354-357
@@ -356,6 +353,6 @@
};
void Act(SourceLocation PragmaLocation,
PragmaMsStackAction Action,
l
d.zobnin.bugzilla added inline comments.
Comment at: lib/Sema/SemaAttr.cpp:277-278
@@ -276,4 @@
- // empty.
- Diag(PragmaLoc, diag::warn_pragma_pop_failed)
- << "pack" << (Name ? "no record matching name" : "stack empty");
-
Here I removed the "
d.zobnin.bugzilla created this revision.
d.zobnin.bugzilla added a reviewer: rnk.
d.zobnin.bugzilla added subscribers: thakis, cfe-commits.
An attempt to make implementation of #pragma pack consistent with other "stack"
pragmas. Also modifies #pragma options align, since it shares the stack with
