This revision was automatically updated to reflect the committed changes.
Closed by commit rL268453: [scan-build] fix dead store warnings emitted on
clang code base (authored by dblaikie).
Changed prior to commit:
http://reviews.llvm.org/D19831?vs=56059&id=56071#toc
Repository:
rL LLVM
http
apelete added a comment.
In http://reviews.llvm.org/D19831#420410, @dblaikie wrote:
> Thanks - do you need someone (me) to commit this, or do you have commit
> access?
I would appreciate if you could commit this for me since I don't have commit
access.
Thanks.
http://reviews.llvm.org/D19831
Thanks - do you need someone (me) to commit this, or do you have commit
access?
On Tue, May 3, 2016 at 1:32 PM, Apelete Seketeli via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> apelete updated this revision to Diff 56059.
> apelete added a comment.
>
> [scan-build] fix dead store warnings
apelete updated this revision to Diff 56059.
apelete added a comment.
[scan-build] fix dead store warnings emitted on clang code base
Changes since last revision:
- Move 'Record' and 'Parent' variables into if() {} scope where they are
actually used.
http://reviews.llvm.org/D19831
Files:
t
dblaikie accepted this revision.
dblaikie added a reviewer: dblaikie.
This revision is now accepted and ready to land.
Comment at: tools/c-index-test/c-index-test.c:1435-1436
@@ -1434,3 +1434,4 @@
/* recurse to get the first parent record that is not anonymous. */
-CXCurs
apelete added a comment.
In http://reviews.llvm.org/D19831#420115, @dblaikie wrote:
> Looks good to me - go ahead & commit whenever you're ready.
If this last revision is good for you, please go ahead and commit this for me
(I don't have commit access).
Thanks.
http://reviews.llvm.org/D1983
apelete updated this revision to Diff 56042.
apelete added a comment.
[scan-build] fix dead store warnings emitted on clang code base
Changes since last revision:
- Initialize 'CXCursor Parent' variable to avoid passing 'Record' variable as
an un-initialized argument thereafter.
http://review
apelete added inline comments.
Comment at: tools/c-index-test/c-index-test.c:1440
@@ -1440,3 +1439,3 @@
Record = Parent;
Parent = clang_getCursorSemanticParent(Record);
RecordIsAnonymous = clang_Cursor_isAnonymous(Record);
This line now
Looks good to me - go ahead & commit whenever you're ready.
On Mon, May 2, 2016 at 11:40 PM, Apelete Seketeli via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> apelete updated this revision to Diff 55952.
> apelete added a comment.
>
> [scan-build] fix dead store warnings emitted on clang co
apelete updated this revision to Diff 55952.
apelete added a comment.
[scan-build] fix dead store warnings emitted on clang code base
Changes since last revision:
- remove dead store since the do {} while() loop overwrite it immediatly anyway.
http://reviews.llvm.org/D19831
Files:
tools/c-i
apelete added a comment.
In http://reviews.llvm.org/D19831#419456, @dblaikie wrote:
> Sorry, I meant remove the /store/, if it's dead. The do/while loop
> overwrites the store immediately, so just remove the assignment to Record?
Makes sense, I overlooked that. Will fix in next revision.
htt
Sorry, I meant remove the /store/, if it's dead. The do/while loop
overwrites the store immediately, so just remove the assignment to Record?
On Mon, May 2, 2016 at 2:59 PM, Apelete Seketeli via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> apelete added a comment.
>
> In http://reviews.llvm
apelete added a comment.
In http://reviews.llvm.org/D19831#419140, @dblaikie wrote:
> Any reason not to remove the story instead?
What do you mean by "remove the story" ?
http://reviews.llvm.org/D19831
___
cfe-commits mailing list
cfe-commits@lis
Any reason not to remove the story instead?
On Mon, May 2, 2016 at 1:36 PM, Apelete Seketeli via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> apelete created this revision.
> apelete added a reviewer: akyrtzi.
> apelete added a subscriber: cfe-commits.
>
> This fixes dead store warnings of
apelete created this revision.
apelete added a reviewer: akyrtzi.
apelete added a subscriber: cfe-commits.
This fixes dead store warnings of the type "dead assignment" reported
by CLang Static Analyzer on the following file:
- tools/c-index-test/c-index-test.c.
Signed-off-by: Apelete Seketeli
15 matches
Mail list logo
