aaron.ballman added inline comments.
Comment at: clang-tidy/utils/Matchers.h:20
@@ -19,1 +19,3 @@
+AST_MATCHER_P(Expr, ignoringImplicit,
+ ast_matchers::internal::Matcher, InnerMatcher) {
alexfh wrote:
> Consider moving this to ASTMatchers.h in a
alexfh accepted this revision.
alexfh added a comment.
This revision is now accepted and ready to land.
LG. Thank you!
Comment at: clang-tidy/utils/Matchers.h:20
@@ -19,1 +19,3 @@
+AST_MATCHER_P(Expr, ignoringImplicit,
+ ast_matchers::internal::Matcher,
etienneb updated this revision to Diff 57316.
etienneb added a comment.
nits: indent
http://reviews.llvm.org/D19841
Files:
clang-tidy/misc/BoolPointerImplicitConversionCheck.cpp
clang-tidy/modernize/UseNullptrCheck.cpp
clang-tidy/performance/FasterStringFindCheck.cpp
etienneb updated this revision to Diff 57314.
etienneb marked an inline comment as done.
etienneb added a comment.
rebase over trunk. matchers are lifted to ASTMatchers.
http://reviews.llvm.org/D19841
Files:
clang-tidy/misc/BoolPointerImplicitConversionCheck.cpp
alexfh added a comment.
In http://reviews.llvm.org/D19841#419488, @etienneb wrote:
> Who is the owner of ASTMatcher?
>
> If he is willing to receive these matchers in ASTMatcher, I'll lift them.
> Otherwise, we should at least lift them within clang-tidy.
Send a patch to sbenza or klimek. I
etienneb added a comment.
Who is the owner of ASTMatcher?
If he is willing to receive these matchers in ASTMatcher, I'll lift them.
Otherwise, we should at least lift them within clang-tidy.
http://reviews.llvm.org/D19841
___
cfe-commits mailing
alexfh requested changes to this revision.
This revision now requires changes to proceed.
Comment at: clang-tidy/utils/Matchers.h:20
@@ -19,1 +19,3 @@
+AST_MATCHER_P(StringLiteral, lengthIs, unsigned, N) {
+ return Node.getLength() == N;
All these should go to
etienneb created this revision.
etienneb added a reviewer: alexfh.
etienneb added a subscriber: cfe-commits.
This patch is lifting matchers used by more than one checkers
to the common namespace.
http://reviews.llvm.org/D19841
Files:
clang-tidy/misc/BoolPointerImplicitConversionCheck.cpp
