etienneb marked an inline comment as done.
etienneb added a comment.
renaming done, landing.
http://reviews.llvm.org/D19846
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
etienneb updated this revision to Diff 56723.
etienneb added a comment.
fix alexfh comments (renaming)
http://reviews.llvm.org/D19846
Files:
clang-tidy/misc/DanglingHandleCheck.cpp
clang-tidy/misc/SuspiciousStringCompareCheck.cpp
clang-tidy/performance/FasterStringFindCheck.cpp
clang-ti
alexfh accepted this revision.
alexfh added a comment.
This revision is now accepted and ready to land.
Looks good with one nit. Thank you!
Comment at: clang-tidy/utils/OptionsUtils.h:21
@@ +20,3 @@
+/// \brief Parse a semicolon separated list of strings.
+std::vector parseStrin
etienneb updated this revision to Diff 56173.
etienneb marked 4 inline comments as done.
etienneb added a comment.
address alexfh comments
http://reviews.llvm.org/D19846
Files:
clang-tidy/misc/DanglingHandleCheck.cpp
clang-tidy/misc/SuspiciousStringCompareCheck.cpp
clang-tidy/performance/
alexfh requested changes to this revision.
This revision now requires changes to proceed.
Comment at: clang-tidy/misc/SuspiciousStringCompareCheck.cpp:94
@@ +93,3 @@
+ std::vector FunctionNames = utils::option::parseNames(
+ (llvm::Twine(KnownStringCompareFunctions) + String
etienneb created this revision.
etienneb added a reviewer: alexfh.
etienneb added a subscriber: cfe-commits.
Lift some common code used by multiple checkers.
This function is also used by checkers that are coming.
It is quite common for a checker to parse a list of names.
http://reviews.llvm.org
