Re: [PATCH] D20112: [OpenMP] Add support for the 'private pointer' flag to signal variables captured in target regions and used in first-private clauses.

ABataev accepted this revision. ABataev added a comment. This revision is now accepted and ready to land. LG http://reviews.llvm.org/D20112 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

Re: [PATCH] D20112: [OpenMP] Add support for the 'private pointer' flag to signal variables captured in target regions and used in first-private clauses.

sfantao added a comment. Hi Alexey, Thanks for the review! Comment at: lib/CodeGen/CGOpenMPRuntime.cpp:5630-5639 @@ -5599,6 +5629,12 @@ // type, the default is 'tofrom'. CurMapTypes.push_back(ElementType->isAggregateType()

Re: [PATCH] D20112: [OpenMP] Add support for the 'private pointer' flag to signal variables captured in target regions and used in first-private clauses.

sfantao updated this revision to Diff 58453. sfantao marked an inline comment as done. sfantao added a comment. - Create function for the generation of the default map information. http://reviews.llvm.org/D20112 Files: lib/CodeGen/CGOpenMPRuntime.cpp

Re: [PATCH] D20112: [OpenMP] Add support for the 'private pointer' flag to signal variables captured in target regions and used in first-private clauses.

ABataev added inline comments. Comment at: lib/CodeGen/CGOpenMPRuntime.cpp:5630-5639 @@ -5599,6 +5629,12 @@ // type, the default is 'tofrom'. CurMapTypes.push_back(ElementType->isAggregateType() ?

Re: [PATCH] D20112: [OpenMP] Add support for the 'private pointer' flag to signal variables captured in target regions and used in first-private clauses.

sfantao updated this revision to Diff 58253. sfantao marked 2 inline comments as done. sfantao added a comment. - Rebase after last changes related to first private. http://reviews.llvm.org/D20112 Files: lib/CodeGen/CGOpenMPRuntime.cpp test/OpenMP/target_firstprivate_codegen.cpp

Re: [PATCH] D20112: [OpenMP] Add support for the 'private pointer' flag to signal variables captured in target regions and used in first-private clauses.

ABataev added a comment. Please, update to latest revision. I made some changes in firstprivates that may affect your patch. Will review it after it. http://reviews.llvm.org/D20112 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

Re: [PATCH] D20112: [OpenMP] Add support for the 'private pointer' flag to signal variables captured in target regions and used in first-private clauses.

sfantao marked 2 inline comments as done. sfantao added a comment. Hi Alexey, Thanks for the review! Comment at: lib/CodeGen/CGOpenMPRuntime.cpp:5452 @@ +5451,3 @@ + // in there. + for (const auto *C : D.getClausesOfKind()) { +for (const auto *D : C->varlists()) {

Re: [PATCH] D20112: [OpenMP] Add support for the 'private pointer' flag to signal variables captured in target regions and used in first-private clauses.

sfantao updated this revision to Diff 57420. sfantao added a comment. - Move the flags adjustment for first private declarations to the mappable expressions handler. http://reviews.llvm.org/D20112 Files: lib/CodeGen/CGOpenMPRuntime.cpp test/OpenMP/target_firstprivate_codegen.cpp

Re: [PATCH] D20112: [OpenMP] Add support for the 'private pointer' flag to signal variables captured in target regions and used in first-private clauses.

ABataev added inline comments. Comment at: lib/CodeGen/CGOpenMPRuntime.cpp:5452 @@ +5451,3 @@ + // in there. + for (const auto *C : D.getClausesOfKind()) { +for (const auto *D : C->varlists()) { I think this is too greedy. You're rescanning list of

[PATCH] D20112: [OpenMP] Add support for the 'private pointer' flag to signal variables captured in target regions and used in first-private clauses.

sfantao created this revision. sfantao added reviewers: ABataev, hfinkel, carlo.bertolli, arpith-jacob, kkwli0. sfantao added subscribers: cfe-commits, caomhin. If a variable is implicitly mapped (doesn't show in a map clause), the runtime library has to be informed if the corresponding capture