Re: [PATCH] D20119: [libunwind] Improve unwinder stack usage

rmaprath added a comment. In http://reviews.llvm.org/D20119#441548, @jroelofs wrote: > In http://reviews.llvm.org/D20119#441516, @rmaprath wrote: > > > Please shout! > > > Just add some parens: > > static_assert((check_fit::does_fit), > "or1k

Re: [PATCH] D20119: [libunwind] Improve unwinder stack usage

jroelofs added a comment. In http://reviews.llvm.org/D20119#441516, @rmaprath wrote: > Please shout! Just add some parens: static_assert((check_fit::does_fit), "or1k registers do not fit into unw_context_t");

Re: [PATCH] D20119: [libunwind] Improve unwinder stack usage

rmaprath added a comment. Looks like this patch breakes gcc builds of libunwind (none of the bots seem to test it though). The problem is two-fold, in `src/config.h` we have: // Define static_assert() unless already defined by compiler.

Re: [PATCH] D20119: [libunwind] Improve unwinder stack usage

rmaprath closed this revision. rmaprath added a comment. Accepted + closed. Patch committed as r270692. http://reviews.llvm.org/D20119 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

Re: [PATCH] D20119: [libunwind] Improve unwinder stack usage

rmaprath added a comment. Committed as r270692. But I forgot to mention this phab review in the commit message. Sigh. http://reviews.llvm.org/D20119 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

Re: [PATCH] D20119: [libunwind] Improve unwinder stack usage

jroelofs added a comment. In http://reviews.llvm.org/D20119#437191, @rmaprath wrote: > In http://reviews.llvm.org/D20119#436849, @jroelofs wrote: > > > In http://reviews.llvm.org/D20119#431997, @rmaprath wrote: > > > > > Addressing review comments from @jroelofs: > > > > > > - Moved the

Re: [PATCH] D20119: [libunwind] Improve unwinder stack usage

jroelofs added a comment. In http://reviews.llvm.org/D20119#431997, @rmaprath wrote: > Addressing review comments from @jroelofs: > > - Moved the assertion in `libunwind.cpp` back to `UnwindCursor.cpp` where it > really belogs. > > @jroelofs: I just realized that, with this new native-only

Re: [PATCH] D20119: [libunwind] Improve unwinder stack usage

rmaprath added a comment. @jroelofs: OK to commit? Thanks. / Asiri http://reviews.llvm.org/D20119 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D20119: [libunwind] Improve unwinder stack usage

rmaprath updated this revision to Diff 57487. rmaprath added a comment. Addressing review comments from @jroelofs: - Moved the assertion in `libunwind.cpp` back to `UnwindCursor.cpp` where it really belogs. @jroelofs: I just realized that, with this new native-only build of `libunwind`, users

Re: [PATCH] D20119: [libunwind] Improve unwinder stack usage

rmaprath added inline comments. Comment at: src/UnwindCursor.hpp:580 @@ -579,3 +605,1 @@ _isSignalFrame(false) { - static_assert(sizeof(UnwindCursor) < sizeof(unw_cursor_t), -"UnwindCursor<> does not fit in unw_cursor_t"); jroelofs

Re: [PATCH] D20119: [libunwind] Improve unwinder stack usage

jroelofs added a comment. Just one question, otherwise LGTM: Comment at: src/UnwindCursor.hpp:580 @@ -579,3 +605,1 @@ _isSignalFrame(false) { - static_assert(sizeof(UnwindCursor) < sizeof(unw_cursor_t), -"UnwindCursor<> does not fit in

Re: [PATCH] D20119: [libunwind] Improve unwinder stack usage

rmaprath added a comment. Ping. http://reviews.llvm.org/D20119 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D20119: [libunwind] Improve unwinder stack usage

rmaprath added a comment. Gentle ping. http://reviews.llvm.org/D20119 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D20119: [libunwind] Improve unwinder stack usage

rmaprath marked an inline comment as done. rmaprath added a comment. http://reviews.llvm.org/D20119 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D20119: [libunwind] Improve unwinder stack usage

rmaprath updated this revision to Diff 56779. rmaprath added a comment. Address review comments by @rengolin: - Define and use `_LIBUNWIND_CONTEXT_SIZE` and `_LIBUNWIND_CURSOR_SIZE` macros http://reviews.llvm.org/D20119 Files: CMakeLists.txt include/__libunwind_config.h

Re: [PATCH] D20119: [libunwind] Improve unwinder stack usage

rengolin added a subscriber: rengolin. Comment at: include/libunwind.h:49 @@ -48,1 +48,3 @@ struct unw_context_t { +#if defined(_LIBUNWIND_NATIVE_I386) + uint64_t data[8]; Wouldn't it be a lot simpler to just define a macro _LIBUNWIND_DATA_SIZE or something

[PATCH] D20119: [libunwind] Improve unwinder stack usage

rmaprath created this revision. rmaprath added reviewers: jroelofs, bcraig. rmaprath added a subscriber: cfe-commits. Herald added a subscriber: aemerson. This patch is generalization of D19920. A new native-only libunwind variant (selectable through the `-DLIBUNWIND_ENABLE_CROSS_UNWINDING=OFF`