Re: [PATCH] D20125: [libclang] Added clang_getRealSpellingLocation to compensate for clang_getSpellingLocation returning the expansion location

2016-05-11 Thread Cameron via cfe-commits
cameron314 updated this revision to Diff 56917. http://reviews.llvm.org/D20125 Files: include/clang-c/Index.h tools/libclang/CXSourceLocation.cpp unittests/libclang/LibclangTest.cpp Index: unittests/libclang/LibclangTest.cpp

Re: [PATCH] D20125: [libclang] Added clang_getRealSpellingLocation to compensate for clang_getSpellingLocation returning the expansion location

2016-05-11 Thread Cameron via cfe-commits
cameron314 updated this revision to Diff 56916. cameron314 added a comment. I've added a unit test. http://reviews.llvm.org/D20125 Files: include/clang-c/Index.h tools/libclang/CXSourceLocation.cpp unittests/libclang/LibclangTest.cpp Index: unittests/libclang/LibclangTest.cpp

Re: [PATCH] D20125: [libclang] Added clang_getRealSpellingLocation to compensate for clang_getSpellingLocation returning the expansion location

2016-05-11 Thread Cameron via cfe-commits
cameron314 added a comment. Ah, I was wondering where the tests were. I found this in the CMake file: # FIXME: libclang unit tests are disabled on Windows due # to failures, mostly in libclang.VirtualFileOverlay_*. if(NOT WIN32 AND CLANG_TOOL_LIBCLANG_BUILD) add_subdirectory(libclang)

Re: [PATCH] D20125: [libclang] Added clang_getRealSpellingLocation to compensate for clang_getSpellingLocation returning the expansion location

2016-05-10 Thread Richard Smith via cfe-commits
rsmith added a comment. Ugh. Yes. I suppose it's too late to make this actually do the right thing. @akyrtzi, what do you think? Please add a test for this (see unittests/libclang/LibclangTest.cpp). http://reviews.llvm.org/D20125 ___ cfe-commits

[PATCH] D20125: [libclang] Added clang_getRealSpellingLocation to compensate for clang_getSpellingLocation returning the expansion location

2016-05-10 Thread Cameron via cfe-commits
cameron314 created this revision. cameron314 added a reviewer: rsmith. cameron314 added a subscriber: cfe-commits. All the libclang functions for expanding a location, namely `clang_getExpansionLocation`, `clang_getPresumedLocation`, `clang_getInstantiationLocation`, and most surprisingly