Re: [PATCH] D20321: [Clang][AVX512][intrinsics] Fix vperm intrinsics.

2016-05-23 Thread Igor Breger via cfe-commits
igorb added a comment. In http://reviews.llvm.org/D20321#436494, @craig.topper wrote: > Looking at this again. This doesn't match the gcc implementation of the > builtins. Unless their header file is also wrong. Can you clarify? Thanks, You are correct. I implemented all changes in code-gen (

Re: [PATCH] D20321: [Clang][AVX512][intrinsics] Fix vperm intrinsics.

2016-05-22 Thread Craig Topper via cfe-commits
craig.topper added a comment. Looking at this again. This doesn't match the gcc implementation of the builtins. Unless their header file is also wrong. Can you clarify? Repository: rL LLVM http://reviews.llvm.org/D20321 ___ cfe-commits mailing l

Re: [PATCH] D20321: [Clang][AVX512][intrinsics] Fix vperm intrinsics.

2016-05-22 Thread Igor Breger via cfe-commits
igorb updated this revision to Diff 58055. igorb added a comment. Update path according to comments. Thanks for review, Craig ! Repository: rL LLVM http://reviews.llvm.org/D20321 Files: include/clang/Basic/BuiltinsX86.def lib/Headers/avx512bwintrin.h lib/Headers/avx512fintrin.h lib/H

Re: [PATCH] D20321: [Clang][AVX512][intrinsics] Fix vperm intrinsics.

2016-05-18 Thread michael zuckerman via cfe-commits
m_zuckerman added a comment. Thanks, you are right ! Repository: rL LLVM http://reviews.llvm.org/D20321 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D20321: [Clang][AVX512][intrinsics] Fix vperm intrinsics.

2016-05-18 Thread Craig Topper via cfe-commits
craig.topper added a subscriber: craig.topper. craig.topper requested changes to this revision. craig.topper added a reviewer: craig.topper. craig.topper added a comment. This revision now requires changes to proceed. Don't the type casts need to be changed too? For example permutexvar_pd has the

Re: [PATCH] D20321: [Clang][AVX512][intrinsics] Fix vperm intrinsics.

2016-05-18 Thread michael zuckerman via cfe-commits
m_zuckerman accepted this revision. m_zuckerman added a comment. This revision is now accepted and ready to land. lgtm Repository: rL LLVM http://reviews.llvm.org/D20321 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.or

[PATCH] D20321: [Clang][AVX512][intrinsics] Fix vperm intrinsics.

2016-05-17 Thread Igor Breger via cfe-commits
igorb created this revision. igorb added reviewers: m_zuckerman, AsafBadouh, delena. igorb added a subscriber: cfe-commits. igorb set the repository for this revision to rL LLVM. [Clang][AVX512][intrinsics] Fix vperm{w|d|q|ps|pd} intrinsics. Index is first argument to buildin function. Reposit