This revision was automatically updated to reflect the committed changes.
Closed by commit rL271310: PCH + module: make sure we write out macros
associated with builtin identifiers. (authored by mren).
Changed prior to commit:
http://reviews.llvm.org/D20383?vs=57673&id=59103#toc
Repository:
rsmith accepted this revision.
rsmith added a comment.
Looks good to me, too.
http://reviews.llvm.org/D20383
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
doug.gregor accepted this revision.
doug.gregor added a comment.
This revision is now accepted and ready to land.
Yes, that's a LGTM, sorry for being unclear.
http://reviews.llvm.org/D20383
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
htt
manmanren added a comment.
In http://reviews.llvm.org/D20383#443613, @doug.gregor wrote:
> Yeah, this looks like the right approach. PCH follows the same rules as
> modules when it comes to newer information shadowing imported information.
Hi Doug,
Thanks for reviewing the patch! Can I take t
doug.gregor added a comment.
Yeah, this looks like the right approach. PCH follows the same rules as modules
when it comes to newer information shadowing imported information.
http://reviews.llvm.org/D20383
___
cfe-commits mailing list
cfe-commits@
manmanren added a comment.
Doug and Richard,
Can you take a look at this when you have time?
Thanks,
Manman
http://reviews.llvm.org/D20383
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-c
benlangmuir added a subscriber: doug.gregor.
benlangmuir added a comment.
I'd like to see Doug and/or Richard review this. It seems reasonable to me to
first blush, but I assume there was a good reason we weren't doing this
already...
http://reviews.llvm.org/D20383
manmanren added a comment.
Thanks Bruno
Comment at: lib/Serialization/ASTWriter.cpp:2191
@@ -2191,1 +2190,3 @@
+// We write out exported module macros for PCH as well.
+if (true) {
auto Leafs = PP.getLeafModuleMacros(Name);
bruno wrote:
> Is this
bruno added a subscriber: bruno.
bruno added a comment.
Hi Manman,
Comment at: lib/Serialization/ASTWriter.cpp:2191
@@ -2191,1 +2190,3 @@
+// We write out exported module macros for PCH as well.
+if (true) {
auto Leafs = PP.getLeafModuleMacros(Name);
-
manmanren created this revision.
manmanren added reviewers: benlangmuir, rsmith.
manmanren added a subscriber: cfe-commits.
When we import a module that defines a builtin identifier from prefix header
and precompile the prefix header, the macro information related to the
identifier is lost.
If w
10 matches
Mail list logo