Re: [PATCH] D20383: PCH + Module: make sure we write out macros associated with builtin identifiers

2016-05-31 Thread Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL271310: PCH + module: make sure we write out macros associated with builtin identifiers. (authored by mren). Changed prior to commit: http://reviews.llvm.org/D20383?vs=57673&id=59103#toc Repository:

Re: [PATCH] D20383: PCH + Module: make sure we write out macros associated with builtin identifiers

2016-05-31 Thread Richard Smith via cfe-commits
rsmith accepted this revision. rsmith added a comment. Looks good to me, too. http://reviews.llvm.org/D20383 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D20383: PCH + Module: make sure we write out macros associated with builtin identifiers

2016-05-31 Thread Doug Gregor via cfe-commits
doug.gregor accepted this revision. doug.gregor added a comment. This revision is now accepted and ready to land. Yes, that's a LGTM, sorry for being unclear. http://reviews.llvm.org/D20383 ___ cfe-commits mailing list cfe-commits@lists.llvm.org htt

Re: [PATCH] D20383: PCH + Module: make sure we write out macros associated with builtin identifiers

2016-05-31 Thread Manman Ren via cfe-commits
manmanren added a comment. In http://reviews.llvm.org/D20383#443613, @doug.gregor wrote: > Yeah, this looks like the right approach. PCH follows the same rules as > modules when it comes to newer information shadowing imported information. Hi Doug, Thanks for reviewing the patch! Can I take t

Re: [PATCH] D20383: PCH + Module: make sure we write out macros associated with builtin identifiers

2016-05-30 Thread Doug Gregor via cfe-commits
doug.gregor added a comment. Yeah, this looks like the right approach. PCH follows the same rules as modules when it comes to newer information shadowing imported information. http://reviews.llvm.org/D20383 ___ cfe-commits mailing list cfe-commits@

Re: [PATCH] D20383: PCH + Module: make sure we write out macros associated with builtin identifiers

2016-05-25 Thread Manman Ren via cfe-commits
manmanren added a comment. Doug and Richard, Can you take a look at this when you have time? Thanks, Manman http://reviews.llvm.org/D20383 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-c

Re: [PATCH] D20383: PCH + Module: make sure we write out macros associated with builtin identifiers

2016-05-23 Thread Ben Langmuir via cfe-commits
benlangmuir added a subscriber: doug.gregor. benlangmuir added a comment. I'd like to see Doug and/or Richard review this. It seems reasonable to me to first blush, but I assume there was a good reason we weren't doing this already... http://reviews.llvm.org/D20383

Re: [PATCH] D20383: PCH + Module: make sure we write out macros associated with builtin identifiers

2016-05-19 Thread Manman Ren via cfe-commits
manmanren added a comment. Thanks Bruno Comment at: lib/Serialization/ASTWriter.cpp:2191 @@ -2191,1 +2190,3 @@ +// We write out exported module macros for PCH as well. +if (true) { auto Leafs = PP.getLeafModuleMacros(Name); bruno wrote: > Is this

Re: [PATCH] D20383: PCH + Module: make sure we write out macros associated with builtin identifiers

2016-05-18 Thread Bruno Cardoso Lopes via cfe-commits
bruno added a subscriber: bruno. bruno added a comment. Hi Manman, Comment at: lib/Serialization/ASTWriter.cpp:2191 @@ -2191,1 +2190,3 @@ +// We write out exported module macros for PCH as well. +if (true) { auto Leafs = PP.getLeafModuleMacros(Name); -

[PATCH] D20383: PCH + Module: make sure we write out macros associated with builtin identifiers

2016-05-18 Thread Manman Ren via cfe-commits
manmanren created this revision. manmanren added reviewers: benlangmuir, rsmith. manmanren added a subscriber: cfe-commits. When we import a module that defines a builtin identifier from prefix header and precompile the prefix header, the macro information related to the identifier is lost. If w