This revision was automatically updated to reflect the committed changes.
jvesely marked 5 inline comments as done.
Closed by commit rL271413: Fixup list of available extensions (authored by
jvesely).
Changed prior to commit:
http://reviews.llvm.org/D20447?vs=59240&id=59254#toc
Repository:
r
Anastasia accepted this revision.
Anastasia added a comment.
This revision is now accepted and ready to land.
LGTM! Thanks!
Repository:
rL LLVM
http://reviews.llvm.org/D20447
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.ll
jvesely updated this revision to Diff 59240.
jvesely added a comment.
Fix typo: COre -> Core
Repository:
rL LLVM
http://reviews.llvm.org/D20447
Files:
include/clang/Basic/OpenCLExtensions.def
test/SemaOpenCL/extension-version.cl
Index: test/SemaOpenCL/extension-version.cl
==
Anastasia added inline comments.
Comment at: test/SemaOpenCL/extension-version.cl:73
@@ +72,3 @@
+
+#endif
+
jvesely wrote:
> Anastasia wrote:
> > Could you put a comment to make it more readable, something like
> >
> > #endif // (__OPENCL_C_VERSION__ < 110)
> T
jvesely marked 2 inline comments as done.
Comment at: test/SemaOpenCL/extension-version.cl:73
@@ +72,3 @@
+
+#endif
+
Anastasia wrote:
> Could you put a comment to make it more readable, something like
>
> #endif // (__OPENCL_C_VERSION__ < 110)
These large block
Anastasia added inline comments.
Comment at: test/SemaOpenCL/extension-version.cl:41
@@ +40,3 @@
+
+// COre features in CL 1.1
+#if (__OPENCL_C_VERSION__ < 110)
COre -> core
Comment at: test/SemaOpenCL/extension-version.cl:73
@@ +72,3 @@
+
+#endi
Anastasia added inline comments.
Comment at: test/SemaOpenCL/extension-version.cl:41
@@ +40,3 @@
+
+// COre features in CL 1.1
+#if (__OPENCL_C_VERSION__ < 110)
Anastasia wrote:
> COre -> core
Actually looking at other comments -> Core
Repository:
rL LLVM
htt
jvesely marked 7 inline comments as done.
Comment at: test/SemaOpenCL/extension-version.cl:12
@@ +11,3 @@
+#ifndef cl_clang_storage_class_specifiers
+#error "Missing cl_clang_storage_class_specifiers define"
+#endif
arsenm wrote:
> When the AMD compiler added thes
arsenm added a subscriber: arsenm.
Comment at: test/SemaOpenCL/extension-version.cl:12
@@ +11,3 @@
+#ifndef cl_clang_storage_class_specifiers
+#error "Missing cl_clang_storage_class_specifiers define"
+#endif
When the AMD compiler added these warnings a long time
jvesely updated this revision to Diff 58806.
jvesely added a comment.
add detection of extensions in early CL versions to test.
Repository:
rL LLVM
http://reviews.llvm.org/D20447
Files:
include/clang/Basic/OpenCLExtensions.def
test/SemaOpenCL/extension-version.cl
Index: test/SemaOpenCL/
yaxunl added inline comments.
Comment at: test/SemaOpenCL/extension-version.cl:11
@@ +10,3 @@
+#endif
+#pragma OPENCL EXTENSION cl_clang_storage_class_specifiers: enable
+
Anastasia wrote:
> jvesely wrote:
> > Anastasia wrote:
> > > jvesely wrote:
> > > > Anastasi
Anastasia added inline comments.
Comment at: test/SemaOpenCL/extension-version.cl:11
@@ +10,3 @@
+#endif
+#pragma OPENCL EXTENSION cl_clang_storage_class_specifiers: enable
+
jvesely wrote:
> Anastasia wrote:
> > jvesely wrote:
> > > Anastasia wrote:
> > > > Could
jvesely added inline comments.
Comment at: test/SemaOpenCL/extension-version.cl:11
@@ +10,3 @@
+#endif
+#pragma OPENCL EXTENSION cl_clang_storage_class_specifiers: enable
+
Anastasia wrote:
> jvesely wrote:
> > Anastasia wrote:
> > > Could you use standard diagnos
Anastasia added inline comments.
Comment at: test/SemaOpenCL/extension-version.cl:11
@@ +10,3 @@
+#endif
+#pragma OPENCL EXTENSION cl_clang_storage_class_specifiers: enable
+
jvesely wrote:
> Anastasia wrote:
> > Could you use standard diagnostic check please:
> >
jvesely added inline comments.
Comment at: test/SemaOpenCL/extension-version.cl:11
@@ +10,3 @@
+#endif
+#pragma OPENCL EXTENSION cl_clang_storage_class_specifiers: enable
+
Anastasia wrote:
> Could you use standard diagnostic check please:
> expected-warning{{un
Anastasia added inline comments.
Comment at: test/SemaOpenCL/extension-version.cl:11
@@ +10,3 @@
+#endif
+#pragma OPENCL EXTENSION cl_clang_storage_class_specifiers: enable
+
Could you use standard diagnostic check please:
expected-warning{{unknown OpenCL extens
jvesely retitled this revision from "[OpenCL] cl_khr_msaa_sharing is OpenCL1.2
extension" to "[OpenCL] Fixup extension list".
jvesely added a subscriber: cfe-commits.
jvesely updated this revision to Diff 58130.
jvesely added a comment.
I went through the specs and fixed up all I could find.
adde
17 matches
Mail list logo