This revision was automatically updated to reflect the committed changes.
Closed by commit rL279803: [clang-tidy] Added hh, hxx and hpp to header guard
checks. (authored by madsravn).
Changed prior to commit:
https://reviews.llvm.org/D20512?vs=69250&id=69320#toc
Repository:
rL LLVM
https://
madsravn updated this revision to Diff 69250.
madsravn added a comment.
Last change - documentation should be fine now.
https://reviews.llvm.org/D20512
Files:
clang-tidy/llvm/HeaderGuardCheck.cpp
clang-tidy/llvm/HeaderGuardCheck.h
clang-tidy/utils/HeaderFileExtensionsUtils.cpp
clang-tid
alexfh added inline comments.
Comment at: docs/clang-tidy/checks/llvm-header-guard.rst:13
@@ +12,2 @@
+
+A comma-separated list of filename extensions of header files (The filename
extension should not contain "." prefix). Default value is ",h,hh,hpp,hxx".
For extension-less he
madsravn added inline comments.
Comment at: docs/clang-tidy/checks/llvm-header-guard.rst:13
@@ +12,3 @@
+
+ ...
+
alexfh wrote:
> `...` was meant to represent the description of the option. Not literally
> `...` ;)
>
> The description should be indented by at l
madsravn updated this revision to Diff 69164.
https://reviews.llvm.org/D20512
Files:
clang-tidy/llvm/HeaderGuardCheck.cpp
clang-tidy/llvm/HeaderGuardCheck.h
clang-tidy/utils/HeaderFileExtensionsUtils.cpp
clang-tidy/utils/HeaderFileExtensionsUtils.h
clang-tidy/utils/HeaderGuard.cpp
cla
alexfh added inline comments.
Comment at: docs/clang-tidy/checks/llvm-header-guard.rst:13
@@ +12,3 @@
+
+ ...
+
`...` was meant to represent the description of the option. Not literally `...`
;)
The description should be indented by at least two columns and sho
madsravn added a comment.
I have commit access. I can commit it myself :) thanks though.
Is the documentation correct? I wasn't sure about the "\n ..." part.
Comment at: clang-tidy/utils/HeaderGuard.h:15
@@ -14,1 +14,3 @@
+#include "../utils/HeaderFileExtensionsUtils.h"
+#incl
madsravn updated this revision to Diff 69158.
madsravn marked 2 inline comments as done.
madsravn added a comment.
Documentation fix.
https://reviews.llvm.org/D20512
Files:
clang-tidy/llvm/HeaderGuardCheck.cpp
clang-tidy/llvm/HeaderGuardCheck.h
clang-tidy/utils/HeaderFileExtensionsUtils.c
alexfh accepted this revision.
alexfh added a comment.
This revision is now accepted and ready to land.
LG with a couple of nits. Do you need me to submit the patch for you? (If yes,
I can fix the doc myself)
Comment at: docs/clang-tidy/checks/llvm-header-guard.rst:8
@@ +7,3 @@
madsravn updated this revision to Diff 69152.
madsravn marked 5 inline comments as done.
madsravn added a comment.
More suggestions by alexfh fixed.
https://reviews.llvm.org/D20512
Files:
clang-tidy/llvm/HeaderGuardCheck.cpp
clang-tidy/llvm/HeaderGuardCheck.h
clang-tidy/utils/HeaderFileEx
alexfh added a comment.
Thank you! I've just noticed that we had completely ignored the actual docs =\
See the inline comment for details.
Comment at: clang-tidy/llvm/HeaderGuardCheck.h:20
@@ -19,1 +19,3 @@
/// Finds and fixes header guards that do not adhere to LLVM style.
+/
madsravn updated this revision to Diff 69143.
madsravn added a comment.
Fixed suggested by alexfh
https://reviews.llvm.org/D20512
Files:
clang-tidy/llvm/HeaderGuardCheck.cpp
clang-tidy/llvm/HeaderGuardCheck.h
clang-tidy/utils/HeaderFileExtensionsUtils.cpp
clang-tidy/utils/HeaderFileExte
alexfh requested changes to this revision.
This revision now requires changes to proceed.
Comment at: clang-tidy/llvm/HeaderGuardCheck.cpp:18
@@ +17,3 @@
+ StringRef extension = ::llvm::sys::path::extension(Filename);
+ if (extension.size() > 0 && extension.front() == '.') {
+
madsravn updated this revision to Diff 69131.
madsravn marked 8 inline comments as done.
madsravn added a comment.
Updated the patch as suggested by hokein and alexfh.
https://reviews.llvm.org/D20512
Files:
clang-tidy/llvm/HeaderGuardCheck.cpp
clang-tidy/llvm/HeaderGuardCheck.h
clang-tidy
hokein added inline comments.
Comment at: clang-tidy/llvm/HeaderGuardCheck.h:19
@@ -18,3 +18,3 @@
/// Finds and fixes header guards that do not adhere to LLVM style.
class LLVMHeaderGuardCheck : public utils::HeaderGuardCheck {
hokein wrote:
> madsravn wrote:
alexfh added inline comments.
Comment at: clang-tidy/llvm/HeaderGuardCheck.cpp:18
@@ +17,3 @@
+ const std::string RawStringHeaderFileExtensions(
+ Options.getLocalOrGlobal("HeaderFileExtensions",
",h,hh,hpp,hxx"));
+ utils::parseHeaderFileExtensions(RawStringHeader
hokein added inline comments.
Comment at: clang-tidy/llvm/HeaderGuardCheck.h:19
@@ -18,3 +18,3 @@
/// Finds and fixes header guards that do not adhere to LLVM style.
class LLVMHeaderGuardCheck : public utils::HeaderGuardCheck {
madsravn wrote:
> hokein wrote:
madsravn added inline comments.
Comment at: clang-tidy/llvm/HeaderGuardCheck.h:19
@@ -18,3 +18,3 @@
/// Finds and fixes header guards that do not adhere to LLVM style.
class LLVMHeaderGuardCheck : public utils::HeaderGuardCheck {
hokein wrote:
> You should add
hokein added a subscriber: hokein.
Comment at: clang-tidy/llvm/HeaderGuardCheck.h:19
@@ -18,3 +18,3 @@
/// Finds and fixes header guards that do not adhere to LLVM style.
class LLVMHeaderGuardCheck : public utils::HeaderGuardCheck {
You should add a document f
madsravn created this revision.
madsravn added reviewers: alexfh, flx.
madsravn added a subscriber: cfe-commits.
Patch for bug 27475: https://llvm.org/bugs/show_bug.cgi?id=27475
I used the suggestion of alexfh to check the header extension.
http://reviews.llvm.org/D20512
Files:
clang-tidy/llv
20 matches
Mail list logo
