bcraig added a comment.
r270735
http://reviews.llvm.org/D20573
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
rmaprath accepted this revision.
rmaprath added a comment.
This revision is now accepted and ready to land.
LGTM.
(I don't have powers to accept libcxx patches in general, but this patch is
quite small and related to something I plugged in, so, I think it's OK in this
instance)
bcraig marked 2 inline comments as done.
bcraig added a comment.
http://reviews.llvm.org/D20573
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
bcraig updated this revision to Diff 58320.
http://reviews.llvm.org/D20573
Files:
CMakeLists.txt
include/__config
include/__config_site.in
include/__threading_support
Index: include/__threading_support
===
---
rmaprath added a comment.
Couple of minor comments. LGTM otherwise.
/ Asiri
Comment at: CMakeLists.txt:387
@@ -386,2 +386,3 @@
+config_define_if(LIBCXX_HAS_PTHREAD_API _LIBCPP_HAS_THREAD_API_PTHREAD)
config_define_if(LIBCXX_HAS_MUSL_LIBC _LIBCPP_HAS_MUSL_LIBC)
bcraig created this revision.
bcraig added reviewers: rmaprath, mclow.lists, EricWF.
bcraig added a subscriber: cfe-commits.
The existing pthread detection code in __config is pretty good for common
operating systems. It doesn't allow cmake-time choices to be made for uncommon
operating
