Re: [PATCH] D21107: Generate codeview for array types

2016-06-07 Thread Adrian McCarthy via cfe-commits
amccarth added inline comments. Comment at: lib/CodeGen/AsmPrinter/CodeViewDebug.cpp:785 @@ +784,3 @@ + TypeIndex IndexType = Asm->MAI->getPointerSize() == 8 ? + TypeIndex(SimpleTypeKind::UInt64) : + TypeIndex(SimpleTypeKind::UInt32); majnemer wrote: >

Re: [PATCH] D21107: Generate codeview for array types

2016-06-07 Thread David Majnemer via cfe-commits
majnemer added a subscriber: majnemer. Comment at: lib/CodeGen/AsmPrinter/CodeViewDebug.cpp:785 @@ +784,3 @@ + TypeIndex IndexType = Asm->MAI->getPointerSize() == 8 ? + TypeIndex(SimpleTypeKind::UInt64) : + TypeIndex(SimpleTypeKind::UInt32); They don't

[PATCH] D21107: Generate codeview for array types

2016-06-07 Thread Adrian McCarthy via cfe-commits
amccarth created this revision. amccarth added a reviewer: rnk. amccarth added a subscriber: cfe-commits. Creates codeview type records for arrays and adds a simple test for one. http://reviews.llvm.org/D21107 Files: lib/CodeGen/AsmPrinter/CodeViewDebug.cpp lib/CodeGen/AsmPrinter/CodeViewD