This revision was automatically updated to reflect the committed changes.
Closed by commit rL275259: [OpenCL] Fix code generation of kernel pipe
parameters. (authored by bader).
Changed prior to commit:
http://reviews.llvm.org/D21744?vs=62100&id=63791#toc
Repository:
rL LLVM
http://reviews.
pxli168 accepted this revision.
pxli168 added a comment.
Sorry for the late reply, I was busy with some backend problem.
LGTM, thanks for the fix!
http://reviews.llvm.org/D21744
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.ll
bader added a comment.
Ping.
Xiuli, do you have any comments?
http://reviews.llvm.org/D21744
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
bader updated this revision to Diff 62100.
bader added a comment.
Re-format the patch.
No functional changes.
http://reviews.llvm.org/D21744
Files:
lib/CodeGen/CodeGenFunction.cpp
test/CodeGenOpenCL/pipe_types.cl
Index: test/CodeGenOpenCL/pipe_types.cl
=
Anastasia accepted this revision.
Anastasia added a comment.
This revision is now accepted and ready to land.
LGTM!
Comment at: lib/CodeGen/CodeGenFunction.cpp:535
@@ -531,3 +534,3 @@
if (isPipe)
-baseTypeName =
-
cast(ty)->getElementType().getCanonicalT
bader created this revision.
bader added reviewers: Anastasia, pxli168.
bader added subscribers: cfe-commits, yaxunl.
Improved test with user define structure pipe type case.
http://reviews.llvm.org/D21744
Files:
lib/CodeGen/CodeGenFunction.cpp
test/CodeGenOpenCL/pipe_types.cl
Index: test/C
