vmiklos abandoned this revision.
vmiklos added a comment.
I see your point, then let me abandon this.
https://reviews.llvm.org/D22237
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
omtcyf0 added a comment.
Hi!
Sorry for a late response.
The issue is that you only deal with the consequences of this "bug". Overridden
functions simply have different USRs, so the solution is just to add relevant
USRs. Trying to deal with it in `USRLocFinder.cpp` doesn't seem right; the
vmiklos updated this revision to Diff 64027.
https://reviews.llvm.org/D22237
Files:
clang-rename/USRLocFinder.cpp
test/clang-rename/VirtualFunction.cpp
Index: test/clang-rename/VirtualFunction.cpp
===
--- /dev/null
+++
vmiklos added a comment.
Forgot to add asserts for main() in the testcase.
https://reviews.llvm.org/D22237
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
vmiklos updated this revision to Diff 64025.
https://reviews.llvm.org/D22237
Files:
clang-rename/USRLocFinder.cpp
test/clang-rename/VirtualFunction.cpp
Index: test/clang-rename/VirtualFunction.cpp
===
--- /dev/null
+++
omtcyf0 added a subscriber: omtcyf0.
omtcyf0 added a comment.
This one doesn't fix it though.
It only deals with declarations of overridden functions.
This is the test that still fails:
/ RUN: cat %s > %t.cpp
// RUN: clang-rename -offset=161 -new-name=boo %t.cpp -i --
// RUN: sed
