This revision was automatically updated to reflect the committed changes.
Closed by commit rL276414: [clang-rename] introduce better symbol finding
(authored by omtcyfz).
Changed prior to commit:
https://reviews.llvm.org/D22465?vs=65066=65067#toc
Repository:
rL LLVM
omtcyfz added inline comments.
Comment at: test/clang-rename/ComplicatedClassType.cpp:1-6
@@ -1,6 +1,7 @@
-// Unsupported test.
// RUN: cat %s > %t.cpp
-// FIXME: This test contains very simple constructions likely to be seen in any
-// project and therefore passing this test is
omtcyfz updated this revision to Diff 65065.
omtcyfz added a comment.
@alexfh, awww, sorry, I've uploaded wrong diff last time for whatever reason...
Can you review the changes please?
Now it contains many new tests and I managed to cut off unnecessary blocks of
code.
omtcyfz updated this revision to Diff 65066.
omtcyfz added a comment.
@alexfh, or wait... It's fine, I just forgot to add few tests, sorry.
https://reviews.llvm.org/D22465
Files:
clang-rename/RenamingAction.cpp
clang-rename/USRFinder.cpp
clang-rename/USRFinder.h
alexfh accepted this revision.
alexfh added a comment.
This revision is now accepted and ready to land.
LG. Thanks!
Comment at: clang-rename/USRFinder.h:49
@@ +48,3 @@
+// FIXME: This wouldn't be needed if
+// RecursiveASTVisitor::VisitNestedNameSpecifier would have been
omtcyfz updated this revision to Diff 65060.
omtcyfz added a comment.
remove redundant `#include` and `using` directives
https://reviews.llvm.org/D22465
Files:
clang-rename/RenamingAction.cpp
clang-rename/USRFinder.cpp
clang-rename/USRFinder.h
clang-rename/USRFindingAction.cpp
omtcyfz updated this revision to Diff 65056.
omtcyfz added a comment.
oops... actually split declarations
https://reviews.llvm.org/D22465
Files:
clang-rename/RenamingAction.cpp
clang-rename/USRFinder.cpp
clang-rename/USRFinder.h
clang-rename/USRFindingAction.cpp
omtcyfz updated this revision to Diff 65054.
omtcyfz added a comment.
split declarations
https://reviews.llvm.org/D22465
Files:
clang-rename/RenamingAction.cpp
clang-rename/USRFinder.cpp
clang-rename/USRFinder.h
clang-rename/USRFindingAction.cpp
clang-rename/USRLocFinder.cpp
omtcyfz updated this revision to Diff 65053.
omtcyfz added a comment.
- reduce rate of hardcoding
- simplify symbol location finding
- introduce tests with templates, some of them are `PASS`ing
https://reviews.llvm.org/D22465
Files:
clang-rename/RenamingAction.cpp
omtcyfz added inline comments.
Comment at: clang-rename/USRFinder.cpp:94
@@ -91,4 +93,3 @@
const auto *Decl = NameLoc.getNestedNameSpecifier()->getAsNamespace();
- if (Decl && !setResult(Decl, NameLoc.getLocalBeginLoc(),
-
omtcyfz updated this revision to Diff 65033.
omtcyfz marked an inline comment as done.
omtcyfz added a comment.
Address comments.
https://reviews.llvm.org/D22465
Files:
clang-rename/RenamingAction.cpp
clang-rename/USRFinder.cpp
clang-rename/USRFinder.h
clang-rename/USRLocFinder.cpp
alexfh requested changes to this revision.
This revision now requires changes to proceed.
Comment at: clang-rename/USRFinder.cpp:81
@@ +80,3 @@
+const auto TypeEndLoc = Loc.getEndLoc(),
+ TypeBeginLoc = Lexer::GetBeginningOfToken(
+ TypeEndLoc,
omtcyfz updated this revision to Diff 64844.
https://reviews.llvm.org/D22465
Files:
clang-rename/RenamingAction.cpp
clang-rename/USRFinder.cpp
clang-rename/USRFinder.h
clang-rename/USRLocFinder.cpp
test/clang-rename/ClassNameInFunctionDefenition.cpp
omtcyfz updated this revision to Diff 64841.
omtcyfz added a comment.
add one more XFAIL test
https://reviews.llvm.org/D22465
Files:
clang-rename/RenamingAction.cpp
clang-rename/USRFinder.cpp
clang-rename/USRFinder.h
clang-rename/USRLocFinder.cpp
omtcyfz updated this revision to Diff 64839.
omtcyfz added a comment.
fix previously unsupported test
https://reviews.llvm.org/D22465
Files:
clang-rename/RenamingAction.cpp
clang-rename/USRFinder.cpp
clang-rename/USRFinder.h
clang-rename/USRLocFinder.cpp
omtcyfz updated this revision to Diff 64838.
omtcyfz added a comment.
few fixes
https://reviews.llvm.org/D22465
Files:
clang-rename/RenamingAction.cpp
clang-rename/USRFinder.cpp
clang-rename/USRFinder.h
clang-rename/USRLocFinder.cpp
test/clang-rename/ClassNameInFunctionDefenition.cpp
omtcyfz added a comment.
ping
https://reviews.llvm.org/D22465
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
omtcyfz updated this revision to Diff 64668.
omtcyfz added a comment.
add support for renaming inside NestedNameSpecifier's
https://reviews.llvm.org/D22465
Files:
clang-rename/RenamingAction.cpp
clang-rename/USRFinder.cpp
clang-rename/USRFinder.h
clang-rename/USRLocFinder.cpp
omtcyfz added a comment.
Can anyone please take a look at this?
My current work is based on this patch and I'd be happy to know I'm doing
things right :)
https://reviews.llvm.org/D22465
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
omtcyfz updated this revision to Diff 64454.
omtcyfz added a comment.
applied few stylistic fixes
https://reviews.llvm.org/D22465
Files:
clang-rename/RenamingAction.cpp
clang-rename/USRFinder.cpp
clang-rename/USRLocFinder.cpp
test/clang-rename/ClassNameInFunctionDefenition.cpp
omtcyfz added a comment.
Removed two `FIXME`s. Seems like types are now handled correctly. +1 test
passing.
https://reviews.llvm.org/D22465
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
omtcyfz updated this revision to Diff 64374.
https://reviews.llvm.org/D22465
Files:
clang-rename/RenamingAction.cpp
clang-rename/USRFinder.cpp
clang-rename/USRLocFinder.cpp
test/clang-rename/ClassNameInFunctionDefenition.cpp
test/clang-rename/ComplicatedClassType.cpp
22 matches
Mail list logo
