sfantao added a comment.
In https://reviews.llvm.org/D22518#500066, @tra wrote:
> Samuel, the patch breaks CUDA. With the patch clang no longer adds include
> paths to standard c++ library during device-side compilation.
> if you run "clang++ -### -c -x cuda /dev/null" you will see that host si
tra added a comment.
Samuel, the patch breaks CUDA. With the patch clang no longer adds include
paths to standard c++ library during device-side compilation.
if you run "clang++ -### -c -x cuda /dev/null" you will see that host side gets
`"-internal-isystem"
"/usr/lib/gcc/x86_64-linux-gnu/4.8/.
tra added a comment.
Looks good.
https://reviews.llvm.org/D22518
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
sfantao added a comment.
Hi Art, Richard,
Thanks for looking at this patch. I tried to address Richard concerns in the
last diff.
Let me know your thoughts,
Thanks again,
Samuel
Comment at: lib/Driver/Tools.cpp:308-335
@@ -349,1 +307,30 @@
+Action::OffloadKind ActiveOffl
sfantao updated this revision to Diff 65747.
sfantao marked 3 inline comments as done.
sfantao added a comment.
- Remove of use of SmallVector and include CUDA args only for the regular
toolchain.
https://reviews.llvm.org/D22518
Files:
lib/Driver/Tools.cpp
test/Driver/cuda-version-check.cu
rsmith added inline comments.
Comment at: lib/Driver/Tools.cpp:308-335
@@ -349,1 +307,30 @@
+Action::OffloadKind ActiveOffloadingKind = Action::OFK_None) {
+ SmallVector RelevantToolChains;
+ // Add the current tool chain to the relevant tool chain list if it is
+ // define
tra accepted this revision.
tra added a comment.
This revision is now accepted and ready to land.
Looks good.
https://reviews.llvm.org/D22518
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-
sfantao created this revision.
sfantao added reviewers: tra, rsmith.
sfantao added subscribers: cfe-commits, rsmith.
This patch aims at removing redundancy in the way include paths for the regular
and offloading toolchains are appended to the arguments list in the clang tool.
This was suggested
