This revision was not accepted when it landed; it landed in state "Needs
Review".
This revision was automatically updated to reflect the committed changes.
Closed by commit rGb839888af8f2: Added 'inline' attribute to
basic_string's destructor (authored by hiraditya).
Herald added subscribers: lib
hiraditya added a comment.
In https://reviews.llvm.org/D22834#522499, @EricWF wrote:
> No benchmark needed but one would be appreciated if possible.
I guess @laxmansole sent you a synthetic benchmark because we were having
trouble integrating it to the libcxx testsuite. I can send you that aga
EricWF added a comment.
No benchmark needed but one would be appreciated if possible.
https://reviews.llvm.org/D22834
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
mclow.lists added a comment.
Eric - did you want to see a benchmark as part of this commit?
https://reviews.llvm.org/D22834
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
laxmansole added a comment.
Ping
https://reviews.llvm.org/D22834
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
hiraditya added a comment.
In https://reviews.llvm.org/D22834#504425, @EricWF wrote:
> LGTM.
>
> However I would like to see a small benchmark that demonstrates the
> performance change. Please try and write the benchmark using Google Benchmark.
> Some helpful links:
>
> http://libcxx.llvm.org/
hiraditya added a comment.
In https://reviews.llvm.org/D22834#504425, @EricWF wrote:
> LGTM.
>
> However I would like to see a small benchmark that demonstrates the
> performance change. Please try and write the benchmark using Google Benchmark.
> Some helpful links:
>
> http://libcxx.llvm.org/
EricWF added a subscriber: EricWF.
EricWF added a comment.
LGTM.
However I would like to see a small benchmark that demonstrates the performance
change. Please try and write the benchmark using Google Benchmark.
Some helpful links:
http://libcxx.llvm.org/docs/TestingLibcxx.html#building-benchma
On Mon, Aug 1, 2016 at 2:20 PM, David Blaikie via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
>
>
> On Tue, Jul 26, 2016 at 4:37 PM Laxman Sole via cfe-commits <
> cfe-commits@lists.llvm.org> wrote:
>
>> laxmansole created this revision.
>> laxmansole added reviewers: mclow.lists, howard.hinn
On Sat, Jul 30, 2016 at 1:47 PM, Joerg Sonnenberger via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> On Tue, Jul 26, 2016 at 10:30:22PM +, Laxman Sole via cfe-commits
> wrote:
> > Currently basic_string's destructor is not getting inlined. So adding
> 'inline' attribute to ~basic_string(
On Sat, Jul 30, 2016 at 12:47 PM, Joerg Sonnenberger via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> On Tue, Jul 26, 2016 at 10:30:22PM +, Laxman Sole via cfe-commits
> wrote:
> > Currently basic_string's destructor is not getting inlined. So adding
> 'inline' attribute to ~basic_string
On Tue, Jul 26, 2016 at 4:37 PM Laxman Sole via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> laxmansole created this revision.
> laxmansole added reviewers: mclow.lists, howard.hinnant.
> laxmansole added subscribers: cfe-commits, sebpop, hiraditya, evandro,
> flyingforyou.
>
>
> Currently b
On Tue, Jul 26, 2016 at 10:30:22PM +, Laxman Sole via cfe-commits wrote:
> Currently basic_string's destructor is not getting inlined. So adding
> 'inline' attribute to ~basic_string().
Does this change the ABI?
Joerg
___
cfe-commits mailing list
c
laxmansole created this revision.
laxmansole added reviewers: mclow.lists, howard.hinnant.
laxmansole added subscribers: cfe-commits, sebpop, hiraditya, evandro,
flyingforyou.
Currently basic_string's destructor is not getting inlined. So adding 'inline'
attribute to ~basic_string().
Worked i
14 matches
Mail list logo
