rengolin closed this revision.
rengolin added a comment.
Committed as r276869.
https://reviews.llvm.org/D22855
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
mstorsjo updated this revision to Diff 65725.
mstorsjo added a comment.
Updated the test to only check what triplet is passed to the assembler
https://reviews.llvm.org/D22855
Files:
lib/Driver/ToolChain.cpp
test/Driver/windows-thumb.s
Index: test/Driver/windows-thumb.s
rengolin added inline comments.
Comment at: test/Driver/thumb-attributes.s:1
@@ +1,2 @@
+@ RUN: %clang -target armv7-windows-itanium -c -o - %s \
+@ RUN: | llvm-readobj -s - | FileCheck %s
mstorsjo wrote:
> rengolin wrote:
> > But we don't usually do asm tests i
mstorsjo added inline comments.
Comment at: test/Driver/thumb-attributes.s:1
@@ +1,2 @@
+@ RUN: %clang -target armv7-windows-itanium -c -o - %s \
+@ RUN: | llvm-readobj -s - | FileCheck %s
rengolin wrote:
> But we don't usually do asm tests in Clang. I can add t
rengolin accepted this revision.
rengolin added a reviewer: rengolin.
rengolin added a comment.
This revision is now accepted and ready to land.
LGTM. I'll add the test to LLVM as a separate commit.
Comment at: lib/Driver/ToolChain.cpp:499
@@ -498,1 +498,3 @@
+ options::
mstorsjo created this revision.
mstorsjo added a subscriber: cfe-commits.
Herald added subscribers: samparker, rengolin, aemerson.
This makes sure that the thumb section flag gets set by the assembler.
This is an alternative fix to D22776.
https://reviews.llvm.org/D22855
Files:
lib/Driver/Too
