This revision was automatically updated to reflect the committed changes.
Closed by commit rL276927: [CUDA] Align kernel launch args correctly when the
LLVM type's alignment is… (authored by jlebar).
Changed prior to commit:
https://reviews.llvm.org/D22879?vs=65800=65824#toc
Repository:
rL
rnk accepted this revision.
rnk added a comment.
This revision is now accepted and ready to land.
lgtm
https://reviews.llvm.org/D22879
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
jlebar added inline comments.
Comment at: test/CodeGenCUDA/kernel-args-alignment.cu:1-2
@@ +1,3 @@
+// REQUIRES: x86-registered-target
+// REQUIRES: nvptx-registered-target
+
rnk wrote:
> Typically clang doesn't need a registered backend for a target to generate
jlebar updated this revision to Diff 65800.
jlebar added a comment.
Remove REQUIRES lines.
https://reviews.llvm.org/D22879
Files:
lib/CodeGen/CGCUDABuiltin.cpp
lib/CodeGen/CGCUDANV.cpp
test/CodeGenCUDA/kernel-args-alignment.cu
Index: test/CodeGenCUDA/kernel-args-alignment.cu
rnk added inline comments.
Comment at: test/CodeGenCUDA/kernel-args-alignment.cu:1-2
@@ +1,3 @@
+// REQUIRES: x86-registered-target
+// REQUIRES: nvptx-registered-target
+
Typically clang doesn't need a registered backend for a target to generate IR
for that
jlebar created this revision.
jlebar added a reviewer: rnk.
jlebar added subscribers: tra, cfe-commits.
Before this patch, we computed the offsets in memory of args passed to
GPU kernel functions by throwing all of the args into an LLVM struct.
clang emits packed llvm structs basically whenever
