Re: [PATCH] D22926: Static Analyzer - Localizability Checker: New Localizable APIs for macOS Sierra

2016-07-30 Thread Devin Coughlin via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL277273: [analyzer] Update APIs taking user-facing strings. (authored by dcoughlin). Changed prior to commit: https://reviews.llvm.org/D22926?vs=66006=66225#toc Repository: rL LLVM

Re: [PATCH] D22926: Static Analyzer - Localizability Checker: New Localizable APIs for macOS Sierra

2016-07-29 Thread Anna Zaks via cfe-commits
zaks.anna accepted this revision. zaks.anna added a comment. This revision is now accepted and ready to land. LGTM Thank you! https://reviews.llvm.org/D22926 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

Re: [PATCH] D22926: Static Analyzer - Localizability Checker: New Localizable APIs for macOS Sierra

2016-07-28 Thread Kulpreet Chilana via cfe-commits
kulpreet updated this revision to Diff 66006. kulpreet added a comment. Sorry, uploaded the wrong patch. This one should compile with the unique variable names. https://reviews.llvm.org/D22926 Files: lib/StaticAnalyzer/Checkers/LocalizationChecker.cpp Index:

Re: [PATCH] D22926: Static Analyzer - Localizability Checker: New Localizable APIs for macOS Sierra

2016-07-28 Thread Devin Coughlin via cfe-commits
dcoughlin added a comment. This doesn't compile for me. It looks like there are two separate declarations of 'buttonWithTitleNSButton'. https://reviews.llvm.org/D22926 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D22926: Static Analyzer - Localizability Checker: New Localizable APIs for macOS Sierra

2016-07-28 Thread Kulpreet Chilana via cfe-commits
kulpreet created this revision. kulpreet added reviewers: zaks.anna, dcoughlin. kulpreet added a subscriber: cfe-commits. - Added in new iOS and macOS APIs that require a localized string - Removed two APIs that incorrectly were marked as requiring a localized string