omtcyfz added a comment.
FYI: I think the diff (accessible by `Download Raw Diff`) is corrupted for some
reason; at least I don't see `Index: test/clang-rename/USRLocFinder.cpp` line
in the end, which should be present, I guess.
Repository:
rL LLVM
https://reviews.llvm.org/D23298
___
This revision was automatically updated to reflect the committed changes.
Closed by commit rL278112: [clang-rename] cleanup: use isWritten (authored by
omtcyfz).
Changed prior to commit:
https://reviews.llvm.org/D23298?vs=67301&id=67309#toc
Repository:
rL LLVM
https://reviews.llvm.org/D2329
omtcyfz added a comment.
Sure.
https://reviews.llvm.org/D23298
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
alexshap added a comment.
> Do you have a commit access or do you need me to land the patch?
No, I don't. I will be grateful to you if you land the patch. Thanks.
https://reviews.llvm.org/D23298
___
cfe-commits mailing list
cfe-commits@lists.llvm.
omtcyfz accepted this revision.
omtcyfz added a comment.
This revision is now accepted and ready to land.
LGTM
Thanks!
Do you have a commit access or do you need me to land the patch?
https://reviews.llvm.org/D23298
___
cfe-commits mailing list
cf
alexshap updated this revision to Diff 67301.
alexshap added a comment.
Fix clang-rename/USRLocFinder.cpp:47 as well
https://reviews.llvm.org/D23298
Files:
clang-rename/USRFinder.cpp
clang-rename/USRLocFinder.cpp
Index: clang-rename/USRLocFinder.cpp
omtcyfz added a comment.
Please fix the same thing @ `USRLocFinder.cpp:47`.
Other than that, looks OK - a bit more readable. Thanks.
https://reviews.llvm.org/D23298
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-b
alexshap created this revision.
alexshap added reviewers: omtcyfz, alexfh.
alexshap added a subscriber: cfe-commits.
alexshap changed the visibility of this Differential Revision from "Public (No
Login Required)" to "All Users".
nit: use isWritten and const auto *Initializer in
NamedDeclFindingA
