Re: [PATCH] D23300: [analyzer] Add "Assuming..." diagnostic pieces for unsupported condition expressions.

2016-09-12 Thread Anna Zaks via cfe-commits
zaks.anna added a comment. @NoQ, Let's test in an IDE. Can you send screenshots? https://reviews.llvm.org/D23300 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D23300: [analyzer] Add "Assuming..." diagnostic pieces for unsupported condition expressions.

2016-08-09 Thread Artem Dergachev via cfe-commits
NoQ added a comment. In https://reviews.llvm.org/D23300#509665, @xazax.hun wrote: > In case there is a more complex condition does it only highligh the part that > influenced taking the branch? > > E.g.: > > if (a || b) { // HIghlight only a, if a was true and b was not evaluated > } >

Re: [PATCH] D23300: [analyzer] Add "Assuming..." diagnostic pieces for unsupported condition expressions.

2016-08-09 Thread Gábor Horváth via cfe-commits
xazax.hun added a comment. In case there is a more complex condition does it only highligh the part that influenced taking the branch? E.g.: if (a || b) { // HIghlight only a, if a was true and b was not evaluated } https://reviews.llvm.org/D23300