tra created this revision.
tra added reviewers: jlebar, sfantao.
tra added a subscriber: cfe-commits.
If they are, we end up with the last intermediary output preserved
in the current directory after compilation.
Added a test case to verify that we're using appropriate filenames
for outputs of di
jlebar added a comment.
Wow, I have no idea if this is right. I can try to figure it out, but if
sfantao can review, that's easier.
Comment at: test/Driver/cuda-bindings.cu:10
@@ +9,3 @@
+// way. Instead we check whether we've generated a permanent name on
+// device side whic
tra updated this revision to Diff 68100.
tra added a comment.
Addressed comments.
https://reviews.llvm.org/D23526
Files:
lib/Driver/Driver.cpp
test/Driver/cuda-bindings.cu
Index: test/Driver/cuda-bindings.cu
===
--- /dev/null
tra marked 2 inline comments as done.
tra added a comment.
https://reviews.llvm.org/D23526
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
sfantao added a comment.
Hi Art,
Thanks for the patch! That looks good.
https://reviews.llvm.org/D23526
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
This revision was automatically updated to reflect the committed changes.
Closed by commit rL279455: [CUDA] Collapsed offload actions should not be
top-level jobs. (authored by tra).
Changed prior to commit:
https://reviews.llvm.org/D23526?vs=68100&id=68896#toc
Repository:
rL LLVM
https://r
