This revision was automatically updated to reflect the committed changes.
Closed by commit rL278988: [Darwin] Stop linking libclang_rt.eprintf.a
(authored by cbieneman).
Changed prior to commit:
https://reviews.llvm.org/D23531?vs=68102&id=68429#toc
Repository:
rL LLVM
https://reviews.llvm.o
Today, the code includes the eprintf archive on all linker invocations for i386
that include the OS X archive.
Removing the eprintf library from the command and including eprintf only for
i386 in the OS X archive should be equivalent to what we have today.
-Chris
> On Aug 16, 2016, at 8:27 AM,
The original motivation for organizing things this way was to try and
always be in the situation where, when linking against the latest
deployment target, we should never need the extra library (because the
content will be present in libSystem). This is useful in helping to ensure
we don't unnecess
beanz updated this revision to Diff 68102.
beanz added a comment.
Herald added a subscriber: mehdi_amini.
Updating code comment and removing unneeded braces.
I'm going to sit on this for a bit before committing in case anyone comes up
with a reason this is a bad idea.
https://reviews.llvm.org/
echristo added a subscriber: echristo.
echristo accepted this revision.
echristo added a reviewer: echristo.
echristo added a comment.
This revision is now accepted and ready to land.
LGTM.
Might want to fix the braces while you're there.
-eric
https://reviews.llvm.org/D23531
__
beanz created this revision.
beanz added reviewers: ddunbar, bob.wilson.
beanz added a subscriber: cfe-commits.
The eprintf library was added before the general OS X builtins library existed
as a place to store one builtin function. Since we have for several years had
an actual mandated builtin
