Re: [PATCH] D23653: Minor cleanup of SimpleTypoCorrector

2016-08-28 Thread Saleem Abdulrasool via cfe-commits
compnerd closed this revision. compnerd added a comment. SVN r279946 https://reviews.llvm.org/D23653 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D23653: Minor cleanup of SimpleTypoCorrector

2016-08-28 Thread Dmitri Gribenko via cfe-commits
gribozavr accepted this revision. gribozavr added a comment. LGTM, thanks! https://reviews.llvm.org/D23653 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D23653: Minor cleanup of SimpleTypoCorrector

2016-08-19 Thread Alexander Shaposhnikov via cfe-commits
alexshap added a reviewer: Eugene.Zelenko. alexshap removed rL LLVM as the repository for this revision. alexshap updated this revision to Diff 68746. alexshap added a comment. 1. clang-tidy -checks=google-explicit-constructor tools/clang/lib/AST/CommentSema.cpp - no other issues found 2. clang-f

Re: [PATCH] D23653: Minor cleanup of SimpleTypoCorrector

2016-08-19 Thread Alexander Shaposhnikov via cfe-commits
alexshap added a comment. i see, it makes sense, thanks. Repository: rL LLVM https://reviews.llvm.org/D23653 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D23653: Minor cleanup of SimpleTypoCorrector

2016-08-19 Thread Eugene Zelenko via cfe-commits
Eugene.Zelenko added a comment. I meant to format only constructor, not entire file. Repository: rL LLVM https://reviews.llvm.org/D23653 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-co

Re: [PATCH] D23653: Minor cleanup of SimpleTypoCorrector

2016-08-19 Thread Alexander Shaposhnikov via cfe-commits
alexshap added a comment. i can do that, although there will be a lot of changes (mostly because of clang-format). Another concern is that the style of the other files located inside the same folder also might be not clang-format compliant. Do you want me to do that ? (i mean to run clang-tidy

Re: [PATCH] D23653: Minor cleanup of SimpleTypoCorrector

2016-08-19 Thread Eugene Zelenko via cfe-commits
Eugene.Zelenko added a subscriber: Eugene.Zelenko. Eugene.Zelenko added a comment. I think will be good idea to run Clang-format over constructor code and Clang-tidy google-explicit-constructor over entire file. Repository: rL LLVM https://reviews.llvm.org/D23653 _

Re: [PATCH] D23653: Minor cleanup of SimpleTypoCorrector

2016-08-19 Thread Alexander Shaposhnikov via cfe-commits
alexshap added a comment. ping https://reviews.llvm.org/D23653 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D23653: Minor cleanup of SimpleTypoCorrector

2016-08-18 Thread Alexander Shaposhnikov via cfe-commits
alexshap added a comment. F2283280: Screen Shot 2016-08-18 at 4.29.34 AM.png https://reviews.llvm.org/D23653 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/

[PATCH] D23653: Minor cleanup of SimpleTypoCorrector

2016-08-18 Thread Alexander Shaposhnikov via cfe-commits
alexshap created this revision. alexshap added reviewers: gribozavr, bkramer. alexshap added a subscriber: cfe-commits. alexshap changed the visibility of this Differential Revision from "Public (No Login Required)" to "All Users". Add the "explicit" specifier to the single-argument constructor o